Repository navigation
Conversation
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 141c0b8843
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…possible to go back the button with spinner
FormAlertWithSubmitButton buttons
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
JakubKorytko
left a comment
There was a problem hiding this comment.
Some comments, otherwise LGTM
Co-authored-by: dariusz-biela <26382728+dariusz-biela@users.noreply.github.com>
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.34-0 🚀
|
|
🤖 I reviewed the changes in this PR against Expensify's help site files under No help site changes are required. This PR is a UI responsiveness/performance improvement: it adds a loading spinner that appears the instant a It does not:
The help site documents what users do and where they do it — this change only affects the visual feedback (a spinner) shown while an existing action is already in progress, which isn't behavior described in any article. Because there's nothing new or changed to document, I did not create a draft docs PR. If you believe a specific article should call out this behavior, reply with the article and what you'd like added and I'll draft it. |
|
Deploy Blocker #96055 was identified to be related to this PR. |
|
Deploy Blocker #96058 was identified to be related to this PR. |
|
This PR failing because of the issue #96058 |
|
Deploy Blocker #96072 was identified to be related to this PR. |
|
Deploy Blocker #96088 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
A spinner has been added to the buttons in
FormAlertWithSubmitButtonto improve responsiveness for users and thus reduce the INP metric for interactions labelled[data-sentry-label="Form-SubmitButton"].A loading spinner now appears on vast majority of the
FormAlertWithSubmitButtonbuttons the instant the button is pressed, beforeonSubmitor any loading state driven by Onyx. These changes add a sharedusePressLoadinghook that holds the logic for showing a spinner immediately on press. The instant spinner is on by default through a newshouldShowLoadingImmediatelyOnPressprop that defaults totrue. Gatekeepers that validate before submitting, such asFormProviderwithFormWrapperandBaseLoginForm, opt out and drive the spinner themselves through the same hook. Some consumers who make early returns viaonSubmitwith state-only change have also been excluded.Under the hood a press flips a local
isPressedflag to true and the actual work is wrapped insetTimeout(…,0). Deferring by one macrotask lets React commitisPressed=trueand paint the spinner before consumer code that may block the JS thread runs.isPressedthen resets on the next tick and hands the loading state over to the consumer's realisLoading, which is usually driven by Onyx. If validation or violations short circuit the submit andisLoadingnever turns true the spinner cancels itself naturally.The navigate forward case needs special handling. When
onSubmitpushes a new screen on top of the current one the current screen stays mounted so a local loading flag would never reset and the spinner would stay stuck on return. Those screens (such asDynamicWorkspaceInvitePage) clear the flag when the screen regains focus throughuseEffectFocus.Fixed Issues
$ #85596
Tests
FormProvider
Account > Profile > Display name
Account > Profile > Contact method (or Workspace > Profile > Name)
Reports / Chat / Tasks
Group chat > Invite participant
Room > Invite member
Expense report > Change approver > Add approver
Report > Create task
Workspace - Rules
Settings > Rules (personal rule)
Workspace > Rules > Merchant rules
Workspace > Rules > Spend rules > Choose cards
Workspace > Rules > Spend rules (rule config)
Workspace > Rules > Spend rules > Spend category
Workspace > Rules > Spend rules > Merchants
Workspace - Workflows
Workspace > Workflows > Create workflow
Workspace > Workflows > Edit workflow
Workspace > Workflows > Expenses from
Workspace - Members & Company cards
Workspace > Members > Invite member
Workspace > Company cards > Settings > Statement close date
Workspace > Company cards > Assign card > Card selection
Domain / Wallet / Sign-in
Account > Domains > Admins > Invite
Account > Wallet > Add bank account > Bank account purpose
Account > Wallet > Report virtual card fraud
Sign-in > Login form
Offline tests
NA
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-06-16.at.14.00.51.mov
Screen.Recording.2026-06-16.at.14.05.25.mov
Screen.Recording.2026-06-16.at.14.13.08.mov
Screen.Recording.2026-06-16.at.14.14.08.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-06-08.at.14.41.15.mov
A1.mov
A5.mov
B3.mov
2.mov
4.mov
5.mov
6.mov