Skip to content

[Due for payment 2026-07-23] AI promo modal - Next button loads infinitely after clicking Next button #96055

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.34-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #92498
Email or phone of affected tester (no customers): jsdijionsdiojisoisoj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Other

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with new account.
  3. Refresh the page.
  4. Click Next button on Concierge AI promo modal.

Expected Result:

Next button will not load infinitely after clicking Next button.

Actual Result:

Next button loads infinitely after clicking Next button.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7207961_1784029122261.2.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7207961

Issue OwnerCurrent Issue Owner: @OlGierd03

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 14, 2026
  2. applause-bot commented on Jul 14, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/6aab0f5ccb5621033a8baad6c55c618906fdc88adda8f02999b79cf0f48fd245

  3. melvin-bot commented on Jul 14, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #92498

  4. melvin-bot commented on Jul 14, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jul 14, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jul 14, 2026

    @MelvinBot
    Contributor

    Proposal

    Root Cause

    Regression from #92498, which added an "instant spinner" to FormAlertWithSubmitButton and made it on by default via shouldShowLoadingImmediatelyOnPress = true (FormAlertWithSubmitButton.tsx:120).

    The AI Features promo modal is a carousel. Its Next button reuses that same FormAlertWithSubmitButton in FeatureTrainingContentBody.tsx:111-117 — with no isLoading prop and no opt-out. Pressing Next on a non-final page runs confirmPage → advanceCarousel(), which only scrolls the carousel to the next page (FeatureTrainingCarousel.tsx:127-133). That is a state-only change.

    The instant spinner is designed to hand off to a real loading state, but neither reset path can ever fire here:

    • The declarative handoff if (isPressed && isLoading) setIsPressed(false) never triggers because no isLoading is passed → it's always false.
    • The useFocusEffect reset never fires because advancing the carousel is inside a modal — the navigation screen never loses/regains focus.

    So isPressed stays true and the Next button spins forever. See usePressLoading.ts:27-58. This is exactly the "consumers who make early returns via onSubmit with state-only change" case the PR intended to exclude but missed for this button.

    Proposed Fix

    Opt this button out of the instant spinner, since its action either advances the carousel (state-only) or navigates back — neither drives a loading state.

    In FeatureTrainingContentBody.tsx:111:

    <FormAlertWithSubmitButton
        onSubmit={() => onConfirm?.(willShowAgain)}
        buttonText={confirmText}
        enabledWhenOffline
        shouldShowLoadingImmediatelyOnPress={false}
        sentryLabel={confirmSentryLabel}
        containerStyles={styles.flex1}
    />
    Why this is the right scope

    This button is shared by every FeatureTrainingModal / FeatureTrainingContent / carousel consumer (feature onboarding modals, AIFeaturesPromoModal, etc.). None of them drive an Onyx isLoading into it, and it lives inside a modal where useFocusEffect won't reset the flag — so the instant spinner can never safely clear for any of them. The final "Get started" page happens to not exhibit the bug only because it calls Navigation.goBack() and unmounts the modal; every intermediate Next press is stuck.

    Alternatively, reverting #92498 would clear this deploy blocker, but the targeted opt-out above is the minimal fix.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/96055) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. OlGierd03 commented on Jul 14, 2026

    @OlGierd03
    Contributor

    Looking into it

  8. OlGierd03 commented on Jul 14, 2026

    @OlGierd03
    Contributor

    @MelvinBot implement this

  9. melvin-bot commented on Jul 14, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  10. rlinoz commented on Jul 14, 2026

    @rlinoz
    Contributor
  11. melvin-bot commented on Jul 14, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  12. removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jul 14, 2026
  13. rlinoz commented on Jul 14, 2026

    @rlinoz
    Contributor

    Fixed here #96063 (comment)

  14. melvin-bot commented on Jul 16, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. changed the title [-]AI promo modal - Next button loads infinitely after clicking Next button[/-] [+][Due for payment 2026-07-23] AI promo modal - Next button loads infinitely after clicking Next button[/+] on Jul 16, 2026
  16. melvin-bot commented on Jul 16, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.34-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-23. 🎊

    For reference, here are some details about the assignees on this issue:

    • @OlGierd03 does not require payment (Contractor)
  17. melvin-bot commented on Jul 16, 2026

    @melvin-bot

    @rlinoz @OlGierd03 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions