You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-07-23] AI promo modal - Next button loads infinitely after clicking Next button #96055
Version Number: 9.4.34-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#92498 Email or phone of affected tester (no customers):jsdijionsdiojisoisoj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Other
Action Performed:
Go to staging.new.expensify.com
Log in with new account.
Refresh the page.
Click Next button on Concierge AI promo modal.
Expected Result:
Next button will not load infinitely after clicking Next button.
Actual Result:
Next button loads infinitely after clicking Next button.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Regression from #92498, which added an "instant spinner" to FormAlertWithSubmitButton and made it on by default via shouldShowLoadingImmediatelyOnPress = true (FormAlertWithSubmitButton.tsx:120).
The AI Features promo modal is a carousel. Its Next button reuses that same FormAlertWithSubmitButton in FeatureTrainingContentBody.tsx:111-117 — with no isLoading prop and no opt-out. Pressing Next on a non-final page runs confirmPage → advanceCarousel(), which only scrolls the carousel to the next page (FeatureTrainingCarousel.tsx:127-133). That is a state-only change.
The instant spinner is designed to hand off to a real loading state, but neither reset path can ever fire here:
The declarative handoff if (isPressed && isLoading) setIsPressed(false) never triggers because no isLoading is passed → it's always false.
The useFocusEffect reset never fires because advancing the carousel is inside a modal — the navigation screen never loses/regains focus.
So isPressed stays true and the Next button spins forever. See usePressLoading.ts:27-58. This is exactly the "consumers who make early returns via onSubmit with state-only change" case the PR intended to exclude but missed for this button.
Proposed Fix
Opt this button out of the instant spinner, since its action either advances the carousel (state-only) or navigates back — neither drives a loading state.
This button is shared by every FeatureTrainingModal / FeatureTrainingContent / carousel consumer (feature onboarding modals, AIFeaturesPromoModal, etc.). None of them drive an Onyx isLoading into it, and it lives inside a modal where useFocusEffect won't reset the flag — so the instant spinner can never safely clear for any of them. The final "Get started" page happens to not exhibit the bug only because it calls Navigation.goBack() and unmounts the modal; every intermediate Next press is stuck.
Alternatively, reverting #92498 would clear this deploy blocker, but the targeted opt-out above is the minimal fix.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/96055) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]AI promo modal - Next button loads infinitely after clicking Next button[/-][+][Due for payment 2026-07-23] AI promo modal - Next button loads infinitely after clicking Next button[/+]on Jul 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.34-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@rlinoz@OlGierd03 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jul 14, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/6aab0f5ccb5621033a8baad6c55c618906fdc88adda8f02999b79cf0f48fd245
melvin-bot commentedon Jul 14, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #92498
melvin-bot commentedon Jul 14, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jul 14, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jul 14, 2026
Proposal
Root Cause
Regression from #92498, which added an "instant spinner" to
FormAlertWithSubmitButtonand made it on by default viashouldShowLoadingImmediatelyOnPress = true(FormAlertWithSubmitButton.tsx:120).The AI Features promo modal is a carousel. Its Next button reuses that same
FormAlertWithSubmitButtoninFeatureTrainingContentBody.tsx:111-117— with noisLoadingprop and no opt-out. Pressing Next on a non-final page runsconfirmPage→advanceCarousel(), which only scrolls the carousel to the next page (FeatureTrainingCarousel.tsx:127-133). That is a state-only change.The instant spinner is designed to hand off to a real loading state, but neither reset path can ever fire here:
if (isPressed && isLoading) setIsPressed(false)never triggers because noisLoadingis passed → it's alwaysfalse.useFocusEffectreset never fires because advancing the carousel is inside a modal — the navigation screen never loses/regains focus.So
isPressedstaystrueand the Next button spins forever. SeeusePressLoading.ts:27-58. This is exactly the "consumers who make early returns viaonSubmitwith state-only change" case the PR intended to exclude but missed for this button.Proposed Fix
Opt this button out of the instant spinner, since its action either advances the carousel (state-only) or navigates back — neither drives a loading state.
In
FeatureTrainingContentBody.tsx:111:Why this is the right scope
This button is shared by every
FeatureTrainingModal/FeatureTrainingContent/ carousel consumer (feature onboarding modals,AIFeaturesPromoModal, etc.). None of them drive an OnyxisLoadinginto it, and it lives inside a modal whereuseFocusEffectwon't reset the flag — so the instant spinner can never safely clear for any of them. The final "Get started" page happens to not exhibit the bug only because it callsNavigation.goBack()and unmounts the modal; every intermediate Next press is stuck.Alternatively, reverting #92498 would clear this deploy blocker, but the targeted opt-out above is the minimal fix.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/96055)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
OlGierd03 commentedon Jul 14, 2026
Looking into it
OlGierd03 commentedon Jul 14, 2026
@MelvinBot implement this
melvin-bot commentedon Jul 14, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
rlinoz commentedon Jul 14, 2026
CP here https://expensify.slack.com/archives/C07J32337/p1784045474204599
melvin-bot commentedon Jul 14, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
rlinoz commentedon Jul 14, 2026
Fixed here #96063 (comment)
melvin-bot commentedon Jul 16, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".[-]AI promo modal - Next button loads infinitely after clicking Next button[/-][+][Due for payment 2026-07-23] AI promo modal - Next button loads infinitely after clicking Next button[/+]melvin-bot commentedon Jul 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.34-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Next buttonin feature training carousel modal #96063If no regressions arise, payment will be issued on 2026-07-23. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 16, 2026
@rlinoz @OlGierd03 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]