Repository navigation
[CP Staging] Fix infinite spinner on the Next button in feature training carousel modal - #96063
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce7dfc0130
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@rlinoz all good now. The one thing I did is that I restricted the scope of the opt-out with a condition instead of using a direct |
|
Testing+! |
|
Both issues fixed |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Next button in feature training carousel modalNext button in feature training carousel modal
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
…eature-training-next-button-infinite-spinner [CP Staging] Fix infinite spinner on the `Next button` in feature training carousel modal (cherry picked from commit 25f8fa8) (cherry-picked to staging by Beamanator)
|
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.4.34-3 🚀
|
|
🤖 I reviewed the changes in this PR against Expensify's help site files under No help site changes are required. This PR is a purely internal UI bug fix: it stops the Next button in the feature training carousel modal from spinning forever by passing The fix only affects a button's loading-spinner behavior — it doesn't change any user-facing feature, workflow, setting, pricing, or product concept that the help site documents. A search of Since no documentation changes are needed, no draft docs PR was created — so there is no linked help site PR to review. @OlGierd03, please confirm you agree there's no help site impact here. If you think an article should be updated, let me know which behavior and I'll create the draft PR. |
|
Fixed Screen.Recording.2026-07-14.at.15.51.03.mov |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.4.35-1 🚀
|
|
🤖 I reviewed this PR against the help site articles in Why: This is an internal UI fix. It passes The help site documents product features, settings, and workflows, none of which are affected here. A search of Since no docs changes are needed, I did not create a draft PR. |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.4.35-6 🚀
|
Explanation of Change
#92498 enabled an optimistic spinner on
FormAlertWithSubmitButtonby default (shouldShowLoadingImmediatelyOnPress = true). The spinner clears only when an externalisLoadingturnstrueor the screen regains navigation focus.The feature training carousel's Next button hits neither path: its
onSubmitonly advances the carousel (local state, noisLoading), and the carousel lives inside a modal, so screen focus never changes. The pressed flag never resets and the button spins forever.The fix is to pass
shouldShowLoadingImmediatelyOnPress={false}inFeatureTrainingContentBody, which is the documented opt-out for exactly this case. Advancing the carousel is a synchronous, state-only change, so there isn't much of pending work for a spinner to represent.Fixed Issues
$ #96055
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2026-07-14.at.16.42.02.mov