Skip to content

[Payment due @mkhutornyi] [No QA] Handle POLICYCHANGELOG_ADD_RULE, UPDATE_RULE, REMOVE_RULE report actions - #98689

Merged
luacmartins merged 9 commits into
mainfrom
luacmartins-policyRuleChangelogActions
Aug 19, 2026
Merged

luacmartins merged 9 commits into
mainfrom
luacmartins-policyRuleChangelogActions

Conversation

@luacmartins

@luacmartins luacmartins commented Aug 14, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Adds App-side support for rendering the new POLICYCHANGELOG_ADD_RULE, UPDATE_RULE, and REMOVE_RULE report actions from Web-Expensify#55203, following the existing static-text policy changelog pattern.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/662964

Tests

N/A this will be tested with the new rules engine BE

  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Not tested - backend feature not fully live yet.

Android: mWeb Chrome

Not tested - backend feature not fully live yet.

iOS: Native

Not tested - backend feature not fully live yet.

iOS: mWeb Safari

Not tested - backend feature not fully live yet.

MacOS: Chrome / Safari

Not tested - backend feature not fully live yet.

Backend added these report action types for the rules engine (see
Web-Expensify PR #55203).
…ctions

Follows the static-string pattern used by other simple policy
changelog actions (e.g. IMPORT_TAGS, CORPORATE_UPGRADE).
@luacmartins luacmartins self-assigned this Aug 14, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/de.ts b/src/languages/de.ts
index d0ef4aee..68998cb0 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -8741,9 +8741,9 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
                 title ? `hat die Agentenregel „${title}“ aktualisiert zu: ${prompt}` : `hat eine Agentenregel aktualisiert zu: ${prompt}`,
             deleted: ({title}: {title: string}) => (title ? `hat die Agentenregel „${title}“ entfernt` : 'hat eine Agentenregel entfernt'),
         },
-        addedRule: 'eine Regel hinzugefügt',
+        addedRule: 'hat eine Regel hinzugefügt',
         updatedRule: 'eine Regel aktualisiert',
-        removedRule: 'eine Regel entfernt',
+        removedRule: 'hat eine Regel entfernt',
         expensifyCardRule: {
             actionVerb: {block: 'blockiert', allow: 'erlaubt'},
             amountOperator: {over: 'über', under: 'unter'},
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index e5d7a087..9f6aff3d 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -8661,9 +8661,9 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
             updated: ({title, prompt}: {title: string; prompt: string}) => (title ? `zaktualizował(a) regułę agenta „${title}” na: ${prompt}` : `zaktualizowano regułę agenta na: ${prompt}`),
             deleted: ({title}: {title: string}) => (title ? `usunął(-ęła) regułę agenta „${title}”` : 'usunięto regułę agenta'),
         },
-        addedRule: 'dodał(-a) regułę',
-        updatedRule: 'zaktualizował(-a) regułę',
-        removedRule: 'usunął(-ęła) regułę',
+        addedRule: 'dodano regułę',
+        updatedRule: 'zaktualizowano regułę',
+        removedRule: 'usunięto regułę',
         expensifyCardRule: {
             actionVerb: {block: 'zablokowane', allow: 'dozwolone'},
             amountOperator: {over: 'ponad', under: 'pod'},
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index cb277a63..36cb06ea 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -8377,9 +8377,9 @@ ${reportName}`,
             updated: ({title, prompt}: {title: string; prompt: string}) => (title ? `已将代理规则“${title}”更新为:${prompt}` : `已将代理规则更新为:${prompt}`),
             deleted: ({title}: {title: string}) => (title ? `已移除代理规则“${title}”` : '已移除代理规则'),
         },
-        addedRule: '已添加规则',
-        updatedRule: '已更新规则',
-        removedRule: '已移除规则',
+        addedRule: '已添加一条规则',
+        updatedRule: '更新了一条规则',
+        removedRule: '已删除一条规则',
         expensifyCardRule: {
             actionVerb: {block: '已阻止', allow: '允许'},
             amountOperator: {over: '结束', under: '在……之下'},

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

@codecov

codecov Bot commented Aug 14, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 94.85% <ø> (ø)
...x/report/actionContents/PolicyChangeLogContent.tsx 100.00% <100.00%> (ø)
src/libs/OptionsListUtils/index.ts 87.35% <50.00%> (-0.17%) ⬇️
src/libs/ReportNameUtils.ts 81.45% <50.00%> (-0.43%) ⬇️
src/libs/SidebarUtils.ts 80.05% <50.00%> (-0.27%) ⬇️
...es/inbox/report/ContextMenu/ContextMenuActions.tsx 40.68% <50.00%> (+0.08%) ⬆️
... and 9 files with indirect coverage changes

@luacmartins luacmartins changed the title Handle POLICYCHANGELOG_ADD_RULE, UPDATE_RULE, REMOVE_RULE report actions [No QA] Handle POLICYCHANGELOG_ADD_RULE, UPDATE_RULE, REMOVE_RULE report actions Aug 17, 2026
@luacmartins
luacmartins marked this pull request as ready for review August 17, 2026 20:53
@luacmartins
luacmartins requested review from a team as code owners August 17, 2026 20:53
@melvin-bot
melvin-bot Bot requested a review from mkhutornyi August 17, 2026 20:53
@luacmartins
luacmartins requested review from JS00001 and removed request for mkhutornyi August 17, 2026 20:53
@melvin-bot
melvin-bot Bot requested review from mkhutornyi and trjExpensify and removed request for a team and JS00001 August 17, 2026 20:53
@melvin-bot

melvin-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 17, 2026 20:53
@luacmartins
luacmartins requested review from JS00001 and removed request for mkhutornyi August 17, 2026 20:53

@mkhutornyi mkhutornyi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider updating below files too:

  • ReportNameUtils for report title
  • OptionsListUtils for search router last message text
  • ContextMenuActions for copy to clipboard

For easier regression catch: test in non-English language

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 03e56937f0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/SidebarUtils.ts Resolved
JS00001
JS00001 previously approved these changes Aug 18, 2026

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. 👍

Add cases for POLICYCHANGELOG_ADD_RULE/UPDATE_RULE/REMOVE_RULE, matching
the existing simple policy changelog actions, so replying to one of
these system messages doesn't fall back to a generic thread title.
OptionsListUtils.getLastMessageTextForReport() is used by search/selector
option construction independently of SidebarUtils, so it needs the same
branches for POLICYCHANGELOG_ADD_RULE/UPDATE_RULE/REMOVE_RULE.
Add clipboard cases for POLICYCHANGELOG_ADD_RULE/UPDATE_RULE/REMOVE_RULE,
matching the other supported policy changelog actions.

luacmartins commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor Author

@mkhutornyi addressed all three

@luacmartins
luacmartins requested a review from mkhutornyi August 18, 2026 20:24
@mkhutornyi

mkhutornyi commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
ios.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mov

Comment thread src/languages/de.ts
Comment on lines +8776 to +8778
addedRule: 'hat eine Regel hinzugefügt',
updatedRule: 'eine Regel aktualisiert',
removedRule: 'hat eine Regel entfernt',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updatedRule seems missing hat

@melvin-bot
melvin-bot Bot requested a review from mjasikowski August 18, 2026 21:01
@melvin-bot

melvin-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot changed the title [No QA] Handle POLICYCHANGELOG_ADD_RULE, UPDATE_RULE, REMOVE_RULE report actions [Payment due @mkhutornyi] [No QA] Handle POLICYCHANGELOG_ADD_RULE, UPDATE_RULE, REMOVE_RULE report actions Aug 18, 2026
@melvin-bot

melvin-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

🎯 @mkhutornyi, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/662964.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@luacmartins
luacmartins requested a review from JS00001 August 18, 2026 21:14
@luacmartins
luacmartins merged commit ace99f2 into main Aug 19, 2026
47 of 49 checks passed
@luacmartins
luacmartins deleted the luacmartins-policyRuleChangelogActions branch August 19, 2026 19:04
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify OSBotify mentioned this pull request Aug 20, 2026
61 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.57-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes required.

I reviewed the changes in this PR against the help site files under docs/articles, and no updates are needed.

Why: This PR is a purely technical rendering change. It adds App-side support for displaying three new policy changelog report actions (POLICYCHANGELOG_ADD_RULE, UPDATE_RULE, REMOVE_RULE) as static system messages in the report timeline, LHN/sidebar, and copy-to-clipboard, plus their translations across all 12 locale files.

These are auto-generated system chat messages ("added a rule" / "updated a rule" / "removed a rule") emitted by the new rules engine backend (which isn't fully live yet). The PR introduces no new user-facing feature, setting, tab, button, or workflow. Help site articles document how customers use features—not the individual changelog messages the system emits in chat—so there's nothing to add or change.

Since no docs changes are required, I did not create a draft help site PR.

@luacmartins, if you believe the underlying rules engine feature itself needs customer-facing documentation (beyond these system messages), let me know and I can scope that separately.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.57-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@melvin-bot

melvin-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown

🤖 Payment issue created: #99123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants