You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-28] Payment issue for E/App PR#98689 #99123
@mkhutornyi The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: new feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
New rules engine is still being worked in backend. No need regression test at the moment.
@MelvinBot I thought there was an update made the past month to post an updated payment summary that had the link to the associated PR in it. I see them sometimes but not all. Review why it wasn't posted here.
Short answer: the PR link comes from a Resolving PRs: block that melvin-bot builds from PRs whose ### Fixed Issues section points at this issue. Nothing points at this one, so the block was dropped.
This issue is an auto-created "Payment issue for E/App PR#98689" issue. PR 98689's Fixed Issues is $ https://github.com/Expensify/Expensify/issues/662964 — it never names this issue, and this issue didn't exist when the PR was opened. So the lookup returns zero PRs and the section is omitted, even though the PR URL is sitting right there in the issue body.
That's why you see it "sometimes but not all": every payment summary that had the block was on a normal bug/feature issue that a PR explicitly linked.
Evidence
The feature is real and roughly a month old. Payment summaries flipped between Aug 6 and Aug 10, 2026:
It fires on linked issues, not on payment issues. From the 2026-08-27/28 batch, every summary with the block was on a regular issue (#94038, #98049, #98312, #98623, #98878, #98990, #99133, …). The only two without it were the two auto-created payment issues: this one and #99231 ("Payment issue for E/App PR#98704").
The trigger is Fixed Issues parsing, not GitHub's cross-reference or "closes" link.
Neither PR 99212 nor PR 98689 has any GitHub closingIssuesReferences, so that isn't the source.
This issue does have a cross-reference from PR 98689 in its timeline and still got no block, so a plain cross-reference isn't enough either.
Suggested fix: for issues titled Payment issue for E/App PR#<n> (and Payment for <PR URL>), fall back to the PR already named in the title/body instead of returning an empty list. That covers every one of these and is exactly the case you're hitting.
I can't implement it — the payment-summary code lives in melvin-bot, outside Expensify/App, so this needs an internal engineer. I didn't find an existing issue tracking it. Want me to open one in Expensify/Expensify?
@MelvinBot open an issue in the E/E assign me, make Weekly and add Task label. If you can find the E/E issue where the payment summary was updated to include the link to the associated PR, link to it in the OP and tag those who are assigned to the issue that is associated with that PR.
The OP carries the root cause and the proposed fix (fall back to the PR named in the payment issue's own title/body when the Resolving PRs lookup comes back empty).
I could not find the issue where the payment summary was updated to include the PR link, so nothing is linked in the OP and no one is tagged. I searched Expensify/Expensify and Expensify/App issues and PRs for "payment summary", "Resolving PRs", and Melvin-titled work across June–August, plus org-wide code search — no match. What I can pin down is the timing: the Resolving PRs: block first appeared between 2026-08-06 and 2026-08-10 (#95191's summary on 08-06 has no block; #95389's on 08-10 does). If you know which issue it was, drop it in and I'll tag the right people.
Activity
melvin-bot commentedon Aug 21, 2026
@mkhutornyi The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
mkhutornyi commentedon Aug 22, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: new feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
New rules engine is still being worked in backend. No need regression test at the moment.
melvin-bot commentedon Aug 27, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Aug 27, 2026
Payment Summary
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Aug 29, 2026
@MelvinBot I thought there was an update made the past month to post an updated payment summary that had the link to the associated PR in it. I see them sometimes but not all. Review why it wasn't posted here.
mallenexpensify commentedon Aug 29, 2026
Payment Summary
Contributor+: @mkhutornyi due $250 via NewDot
Also just realized my above comment to Melv is likely cuz it's a payment issue, I'd still like it though cuz it saves me time opening the PR. ¯_(ツ)_/¯
MelvinBot commentedon Aug 29, 2026
Short answer: the PR link comes from a
Resolving PRs:block that melvin-bot builds from PRs whose### Fixed Issuessection points at this issue. Nothing points at this one, so the block was dropped.This issue is an auto-created "Payment issue for E/App PR#98689" issue. PR 98689's
Fixed Issuesis$ https://github.com/Expensify/Expensify/issues/662964— it never names this issue, and this issue didn't exist when the PR was opened. So the lookup returns zero PRs and the section is omitted, even though the PR URL is sitting right there in the issue body.That's why you see it "sometimes but not all": every payment summary that had the block was on a normal bug/feature issue that a PR explicitly linked.
Evidence
The feature is real and roughly a month old. Payment summaries flipped between Aug 6 and Aug 10, 2026:
Resolving PRsIt fires on linked issues, not on payment issues. From the 2026-08-27/28 batch, every summary with the block was on a regular issue (#94038, #98049, #98312, #98623, #98878, #98990, #99133, …). The only two without it were the two auto-created payment issues: this one and #99231 ("Payment issue for E/App PR#98704").
The trigger is
Fixed Issuesparsing, not GitHub's cross-reference or "closes" link.$ .../issues/99138and$ .../issues/99133inFixed Issues→ [Due for payment 2026-08-29] Expense - Unable to split expense with deleted tax #99133's summary showsResolving PRs: .../pull/99212.closingIssuesReferences, so that isn't the source.Suggested fix: for issues titled
Payment issue for E/App PR#<n>(andPayment for <PR URL>), fall back to the PR already named in the title/body instead of returning an empty list. That covers every one of these and is exactly the case you're hitting.I can't implement it — the payment-summary code lives in melvin-bot, outside
Expensify/App, so this needs an internal engineer. I didn't find an existing issue tracking it. Want me to open one inExpensify/Expensify?view run
mallenexpensify commentedon Aug 29, 2026
@MelvinBot open an issue in the E/E assign me, make Weekly and add Task label. If you can find the E/E issue where the payment summary was updated to include the link to the associated PR, link to it in the OP and tag those who are assigned to the issue that is associated with that PR.
MelvinBot commentedon Aug 29, 2026
Created: https://github.com/Expensify/Expensify/issues/676523 — assigned to you, labeled
Weekly+Task.The OP carries the root cause and the proposed fix (fall back to the PR named in the payment issue's own title/body when the
Resolving PRslookup comes back empty).I could not find the issue where the payment summary was updated to include the PR link, so nothing is linked in the OP and no one is tagged. I searched
Expensify/ExpensifyandExpensify/Appissues and PRs for "payment summary", "Resolving PRs", and Melvin-titled work across June–August, plus org-wide code search — no match. What I can pin down is the timing: theResolving PRs:block first appeared between 2026-08-06 and 2026-08-10 (#95191's summary on 08-06 has no block; #95389's on 08-10 does). If you know which issue it was, drop it in and I'll tag the right people.view run
trjExpensify commentedon Oct 1, 2026
approved $250 for @mkhutornyi