Skip to content

[Due for payment 2026-08-28] Payment issue for E/App PR#98689 #99123

Closed

Description

@melvin-bot

Issue created to compensate the Contributor+ member for their work on #98689
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/662964.
Contributor+ member who reviewed the PR - @mkhutornyi.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Aug 21, 2026

    @melvin-bot
    Author

    @mkhutornyi The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  2. mkhutornyi commented on Aug 22, 2026

    @mkhutornyi
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: new feature

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    New rules engine is still being worked in backend. No need regression test at the moment.

  3. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 22, 2026
  4. melvin-bot commented on Aug 27, 2026

    @melvin-bot
    Author

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  5. melvin-bot commented on Aug 27, 2026

    @melvin-bot
    Author

    Payment Summary

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  6. mallenexpensify commented on Aug 29, 2026

    @mallenexpensify
    Contributor

    @MelvinBot I thought there was an update made the past month to post an updated payment summary that had the link to the associated PR in it. I see them sometimes but not all. Review why it wasn't posted here.

  7. mallenexpensify commented on Aug 29, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @mkhutornyi due $250 via NewDot

    Also just realized my above comment to Melv is likely cuz it's a payment issue, I'd still like it though cuz it saves me time opening the PR. ¯_(ツ)_/¯

  8. MelvinBot commented on Aug 29, 2026

    @MelvinBot
    Contributor

    Short answer: the PR link comes from a Resolving PRs: block that melvin-bot builds from PRs whose ### Fixed Issues section points at this issue. Nothing points at this one, so the block was dropped.

    This issue is an auto-created "Payment issue for E/App PR#98689" issue. PR 98689's Fixed Issues is $ https://github.com/Expensify/Expensify/issues/662964 — it never names this issue, and this issue didn't exist when the PR was opened. So the lookup returns zero PRs and the section is omitted, even though the PR URL is sitting right there in the issue body.

    That's why you see it "sometimes but not all": every payment summary that had the block was on a normal bug/feature issue that a PR explicitly linked.

    Evidence

    The feature is real and roughly a month old. Payment summaries flipped between Aug 6 and Aug 10, 2026:

    Issue Summary posted Resolving PRs
    #96297 2026-08-02 no
    #95191 2026-08-06 no
    #95389 2026-08-10 yes

    It fires on linked issues, not on payment issues. From the 2026-08-27/28 batch, every summary with the block was on a regular issue (#94038, #98049, #98312, #98623, #98878, #98990, #99133, …). The only two without it were the two auto-created payment issues: this one and #99231 ("Payment issue for E/App PR#98704").

    The trigger is Fixed Issues parsing, not GitHub's cross-reference or "closes" link.

    • PR 99212 lists $ .../issues/99138 and $ .../issues/99133 in Fixed Issues → [Due for payment 2026-08-29] Expense - Unable to split expense with deleted tax #99133's summary shows Resolving PRs: .../pull/99212.
    • Neither PR 99212 nor PR 98689 has any GitHub closingIssuesReferences, so that isn't the source.
    • This issue does have a cross-reference from PR 98689 in its timeline and still got no block, so a plain cross-reference isn't enough either.

    Suggested fix: for issues titled Payment issue for E/App PR#<n> (and Payment for <PR URL>), fall back to the PR already named in the title/body instead of returning an empty list. That covers every one of these and is exactly the case you're hitting.

    I can't implement it — the payment-summary code lives in melvin-bot, outside Expensify/App, so this needs an internal engineer. I didn't find an existing issue tracking it. Want me to open one in Expensify/Expensify?


    view run

  9. mallenexpensify commented on Aug 29, 2026

    @mallenexpensify
    Contributor

    @MelvinBot open an issue in the E/E assign me, make Weekly and add Task label. If you can find the E/E issue where the payment summary was updated to include the link to the associated PR, link to it in the OP and tag those who are assigned to the issue that is associated with that PR.

  10. MelvinBot commented on Aug 29, 2026

    @MelvinBot
    Contributor

    Created: https://github.com/Expensify/Expensify/issues/676523 — assigned to you, labeled Weekly + Task.

    The OP carries the root cause and the proposed fix (fall back to the PR named in the payment issue's own title/body when the Resolving PRs lookup comes back empty).

    I could not find the issue where the payment summary was updated to include the PR link, so nothing is linked in the OP and no one is tagged. I searched Expensify/Expensify and Expensify/App issues and PRs for "payment summary", "Resolving PRs", and Melvin-titled work across June–August, plus org-wide code search — no match. What I can pin down is the timing: the Resolving PRs: block first appeared between 2026-08-06 and 2026-08-10 (#95191's summary on 08-06 has no block; #95389's on 08-10 does). If you know which issue it was, drop it in and I'll tag the right people.


    view run

  11. trjExpensify commented on Oct 1, 2026

    @trjExpensify
    Contributor

    approved $250 for @mkhutornyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions