Repository navigation
[CP Staging] Fix unable to delete split - #99622
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariCleanShot.2026-08-27.at.10.40.47.1.mp4 |
|
🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Fix unable to delete split (cherry picked from commit bc54639) (cherry-picked to staging by AndrewGable)
|
🔁 Filed a Staging retest request for deploy blockers #99610 after this PR was cherry-picked to staging. |
|
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.4.62-3 🚀
|
Help site review — no changes requiredI reviewed the changes in this PR against the help site articles under Why: This is an internal bug fix, not a behavior or feature change. The diff renames a routing param ( The documented, user-facing behavior is unchanged — the existing article Split Expenses already accurately describes removing a split under "How to remove a split row" (Tap a split row → Remove split → Save). The fix simply makes the app behave the way the help site already says it should, so there's nothing to add, remove, or correct. Since no changes are needed, I did not open a draft docs PR. @huult, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.62-4 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.4.63-0 🚀
|
Help site review — no changes requiredI reviewed the changes in this PR against the help site articles under Why: This is an internal bug fix, not a behavior or feature change. The diff renames a routing param ( The documented, user-facing behavior is unchanged — the existing article Split Expenses already accurately describes removing a split under "How to remove a split row" (Tap a split row → Remove split → Save). The fix simply makes the app behave the way the help site already says it should, so there's nothing to add, remove, or correct. Since no changes are needed, I did not open a draft docs PR. @huult, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.63-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #99610
PROPOSAL:
Tests
Same QA step
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-08-27.at.08.42.06.mov