Skip to content

[Due for payment 2026-09-03] Expense - Unable to delete split #99610

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.62-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #98547
Email or phone of affected tester (no customers): sdsiodjnosdjiodsj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create an expense.
  4. Open the expense.
  5. Click More > Split > Add split > Save.
  6. Open any split.
  7. Click Amount.
  8. Click on the current split.
  9. Click Remove split.
  10. Open other split.
  11. Click Remove split.

Expected Result:

Split will be removed.

Actual Result:

Split cannot be removed.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7243701_1787781843159.2.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7243701

Issue OwnerCurrent Issue Owner: @suneox

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 26, 2026
  2. applause-bot commented on Aug 26, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/9f06c2f97d0e740812ce005791129b3471abd140326079f45e718c065d2f0acc

  3. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #98547

  4. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    @mjasikowski @suneox you have been assigned to this deploy blocker because you reviewed the offending PR: #98547

  5. github-actions commented on Aug 26, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    @huult you have been assigned to this deploy blocker because you authored the offending PR: #98547

  7. melvin-bot commented on Aug 26, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. MelvinBot commented on Aug 26, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis: Unable to delete split

    Root cause: PR #98547 (migrate SPLIT_EXPENSE_EDIT to a dynamic route) introduced a route param-name collision on splitExpenseTransactionID. The split-overview route declares it as a query param (ROUTES.ts:405) while the new split-edit suffix declares the same name as a path param (ROUTES.ts:449). When you open the edit page from the "edit splits" overview, the inherited query value shadows the path value, so removeSplitExpenseField filters the wrong split — and the split you're viewing is never removed. Confidence: High that #98547 is the causing PR; Medium on this exact mechanism (see caveat below).

    Recommended resolution: revert #98547. It's a pure navigation/route migration (no user-facing feature), it's the only PR in this release touching the split-edit flow, and the regression is staging-only (works in production) — so reverting cleanly restores working behavior.

    Assignees: huult (author), suneox + mjasikowski (reviewers) are already assigned — no change needed.

    Evidence & mechanism

    Why #98547:

    • Regression reproduces on staging 9.4.62-1 but not production → introduced in this deploy. migrate SPLIT_EXPENSE_EDIT #98547 is item 15 in the StagingDeployCash checklist (Deploy Checklist: New Expensify 2026-08-26 #99596), merged 2026-08-26.
    • It rewrote exactly the affected flow: renamed SPLIT_EXPENSE_EDIT → DYNAMIC_SPLIT_EXPENSE_EDIT, SplitExpenseEditPage.tsx → DynamicSplitExpenseEditPage.tsx (the page rendering the "Remove split" button), and converted the static route into a nested dynamic route resolving params via query-param inheritance from the parent overview route. The repro path (open split → Amount → tap a split → edit → Remove split) traverses precisely this param plumbing.
    • It's the only split-expense-edit PR in the release.

    Mechanism:

    • "Remove split" calls removeSplitExpenseField(draftTransactionWithSplitExpenses, splitExpenseTransactionID, …) at DynamicSplitExpenseEditPage.tsx:561; splitExpenseTransactionID is read from route.params at DynamicSplitExpenseEditPage.tsx:102 and identifies which split to filter out (SplitExpenseItems.ts:719-730).
    • Tapping a split builds the edit URL via createDynamicRoute(...) using the current overview URL as the base (DynamicSplitExpensePage.tsx:611). If the overview carries splitExpenseTransactionID in its query (edit-splits mode, DynamicSplitExpensePage.tsx:590-591), the final URL defines splitExpenseTransactionID twice — inherited query (originally-focused split) + edit suffix path param (the tapped split).
    • createDynamicRoute's collision guard (mergeQueryStrings) only detects query-vs-query duplicates; it does not catch a query-vs-path clash. The inherited query value shadows the path value, so the edit page resolves the wrong split, and removeSplitExpenseField never filters the one you're viewing. The button still renders because splitExpensesList (derived from the correctly-inherited originalTransactionID draft) still has length > 1.
    • Pre-migrate SPLIT_EXPENSE_EDIT #98547, the static route carried transactionID/splitExpenseTransactionID/backTo explicitly in its own path — no parent-inheritance shadowing — which is why production is unaffected. The PR's added test only covers a transactionID collision with expense-step screens, not this splitExpenseTransactionID query-vs-path case.

    Caveat: the causing PR is High confidence; the exact query-vs-path shadowing is my strongest code-grounded mechanism but I couldn't execute the route parser at runtime to observe the resolved params. A getStateFromPath trace on the nested overview→edit URL would confirm it definitively — the author/reviewers can verify quickly.

    If reverting is undesirable — forward-fix: rename the edit suffix's path param (:splitExpenseTransactionID? → e.g. :editSplitTransactionID?) and read the new name on the edit page, or stop propagating the overview's splitExpenseTransactionID query param when navigating into the edit route. Either removes the shadowing.

    Runtime reproduction: attempted via the web tester but blocked by a session/test-infra issue (the browser session rendered a blank page with no DOM/network activity, while the dev server itself returned 200 with valid HTML) — so this analysis is code-grounded, not runtime-confirmed.


    view run

  9. mjasikowski commented on Aug 27, 2026

    @mjasikowski
    Contributor
  10. IuliiaHerets commented on Aug 27, 2026

    @IuliiaHerets

    Not repro on Mac 26.5.1 Safari
    v9.4.62-4

    529ba94edfb7f3f654b084fc6d6ed13c.mp4
  11. changed the title [-]Expense - Unable to delete split[/-] [+][Due for payment 2026-09-03] Expense - Unable to delete split[/+] on Aug 27, 2026
  12. melvin-bot commented on Aug 27, 2026

    @melvin-bot

    @suneox / @huult

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.62-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-09-03. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions