Repository navigation
migrate SPLIT_EXPENSE_EDIT - #98547
mjasikowski merged 17 commits into
Conversation
…-expense-workspace-general-v2
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b05f023dc8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…-expense-workspace-general-v2
|
@suneox it's ready for review |
|
The failed unit tests are not related to this PR. |
Manual test cases
|
…-expense-workspace-general-v2
JmillsExpensify
left a comment
There was a problem hiding this comment.
No product review required.
…-expense-workspace-general-v2
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariCleanShot.2026-08-17.at.15.02.00.1.mp4CleanShot.2026-08-17.at.15.13.21.1.mp4
|
|
@huult Could you please take a look at the failing typecheck? |
…-expense-workspace-general-v2
it's done |
This comment was marked as off-topic.
This comment was marked as off-topic.
…-expense-workspace-general-v2
…-expense-workspace-general-v2
…-expense-workspace-general-v2
…-expense-workspace-general-v2
…-expense-workspace-general-v2
Screen.Recording.2026-08-22.at.23.01.46.mov@suneox It's ready for your review again. The messy link issue was fixed after merging the Split Overview dynamic link. I only updated the transactionId parameter because the pages after this also need the transactionId param, so I renamed it to avoid duplicate params and issues opening the page description or category, date... |
…-expense-workspace-general-v2
|
🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.4.62-1 🚀
|
Help site review — no changes required 📚I reviewed the changes in this PR and no updates are needed to the help site files under Why: This PR is a purely internal navigation/route migration for the split expense edit screen. It:
None of this changes any user-facing behavior, feature names, tab/settings labels, or buttons. The split expense feature works exactly the same from a user's perspective, so the existing Split-Expenses.md article remains accurate. Help articles document product behavior, not internal route constants or deep-link paths. Since no help content is affected, I did not create a draft docs PR. |
|
Deploy Blocker #99610 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.62-4 🚀
Bundle Size Analysis (Sentry): |
| Navigation.navigate(splitExpenseOverviewRoute); | ||
| Navigation.navigate(createDynamicRoute(DYNAMIC_ROUTES.SPLIT_EXPENSE_EDIT.getRoute(reportID, transaction.transactionID), splitExpenseOverviewRoute)); |
There was a problem hiding this comment.
Checklist:
This PR caused a regression: #100130
The two Navigation.navigate calls hererun in the same tick, so the edit page replaces the split overview. Because of that, Remove split closes the RHP instead of going back to the overview, and the expense doesn't go back to the original.
|
Coming from Spend - Not here page opens after clicking split row on Date tab when opened from Spend: This PR changed split-row navigation from a standalone edit URL to a dynamic suffix appended to the active Date-tab URL:
That URL matches the existing legacy date redirect, which rewrites it to |

























Explanation of Change
Fixed Issues
$ #83829
PROPOSAL:
Tests
Same QA step
Offline tests
QA Steps
Prerequisites
Test 1: Navigation from report entry point
Test 2: Navigation from search entry point
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-08-13.at.14.47.36.mov