Skip to content

[BT-101] Migrate Split Expense + Workspace General #83829

Closed

Description

@mjasikowski

Description

Current State:

  • 5 routes for split expense and workspace general navigation
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (5):

Route Constant Path
SPLIT_EXPENSE_EDIT edit/split-expense/overview/:reportID/:transactionID
SUBMIT_EXPENSE submit-expense
WORKSPACES_LIST workspaces
WORKSPACE_INITIAL workspaces/:policyID
WORKSPACE_OVERVIEW workspaces/:policyID/overview

Usages

SPLIT_EXPENSE_EDIT:

  • src/pages/iou/SplitExpenseEditPage.tsx - Main entry point

SUBMIT_EXPENSE:

  • Search for usages in expense submission flow

WORKSPACES_LIST:

  • src/pages/workspace/WorkspacesListPage.tsx - Main entry point

WORKSPACE_INITIAL:

  • src/pages/workspace/WorkspacesListPage.tsx:521
  • src/pages/ReportDetailsPage.tsx:530,745
  • src/libs/actions/App.ts:486
  • src/pages/workspace/WorkspaceJoinUserPage.tsx:40
  • src/pages/workspace/WorkspaceConfirmationPage.tsx:26
  • src/libs/PolicyUtils.ts:1391

WORKSPACE_OVERVIEW:

  • src/pages/workspace/WorkspacesListPage.tsx:524
  • src/pages/workspace/AccessOrNotFoundWrapper.tsx:122
  • src/pages/ReportDetailsPage.tsx:532
  • src/libs/ReportUtils.ts:11547

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • SPLIT_EXPENSE_EDIT
  • SUBMIT_EXPENSE
  • WORKSPACES_LIST
  • WORKSPACE_INITIAL
  • WORKSPACE_OVERVIEW
Issue OwnerCurrent Issue Owner: @suneox

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 2, 2026
  2. melvin-bot commented on Apr 20, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @mananjadhav, @mjasikowski, @huult eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  3. 45 remaining items

  4. mitarachim commented on Aug 26, 2026

    @mitarachim

    Deploy Blocker #99610 was identified to be related to the PR #98547 that attempted to fix this issue.

  5. melvin-bot commented on Aug 27, 2026

    @melvin-bot

    @suneox / @huult

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.62-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-09-03. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  6. melvin-bot commented on Aug 31, 2026

    @melvin-bot

    @suneox Whoops! This issue is 2 days overdue. Let's get this updated quick!

  7. huult commented on Sep 2, 2026

    @huult
    Contributor

    @mjasikowski we can close this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2InternalRequires API changes or must be handled by Expensify staffSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions