Skip to content

fix(ci): expose esptool to daemon baseline - #1178

Merged
zackees merged 1 commit into
mainfrom
fix/ci-esptool-daemon-path
Jul 25, 2026
Merged

fix(ci): expose esptool to daemon baseline#1178
zackees merged 1 commit into
mainfrom
fix/ci-esptool-daemon-path

Conversation

@zackees

@zackees zackees commented Jul 25, 2026

Copy link
Copy Markdown
Member

The fbuild daemon intentionally starts from a clean Unix login environment, so the existing GitHub PATH entry at ~/.local/bin is not visible to ESP32 firmware conversion. Link the already verified pip launcher into /usr/local/bin, which is part of that clean baseline.\n\nValidated locally: workflow render check and git diff --check.\n\nFixes the post-merge ESP32 board failures after #1177.

Summary by CodeRabbit

  • Bug Fixes
    • Improved ESP32 firmware conversion setup by ensuring the firmware tooling is available system-wide.
    • Added an installation verification step to confirm the tool is ready before proceeding.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a29c68b4-0f1e-4f70-83dd-ad4e0bf036a7

📥 Commits

Reviewing files that changed from the base of the PR and between 2e8a796 and 8d1dbf9.

📒 Files selected for processing (1)
  • .github/workflows/template_build.yml

📝 Walkthrough

Walkthrough

The firmware build workflow now symlinks the installed esptool executable to /usr/local/bin/esptool and verifies it with the version command.

Changes

esptool availability

Layer / File(s) Summary
Create and verify system esptool link
.github/workflows/template_build.yml
The workflow exposes the resolved esptool executable at /usr/local/bin/esptool and verifies the installation by running its version command.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • FastLED/fbuild#1177: Updates the same Install esptool workflow step with an alternative PATH-based availability and verification approach.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects exposing esptool in CI for the daemon baseline environment.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ci-esptool-daemon-path

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit c2be6d1 into main Jul 25, 2026
89 of 93 checks passed
@zackees
zackees deleted the fix/ci-esptool-daemon-path branch July 25, 2026 01:02
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant