Skip to content

fix: preserve launcher PATH for daemon tools - #1179

Merged
zackees merged 1 commit into
mainfrom
fix/daemon-inherit-tool-path
Jul 25, 2026
Merged

fix: preserve launcher PATH for daemon tools#1179
zackees merged 1 commit into
mainfrom
fix/daemon-inherit-tool-path

Conversation

@zackees

@zackees zackees commented Jul 25, 2026

Copy link
Copy Markdown
Member

Replaces the sudo /usr/local/bin workaround from #1178.\n\nThe detached daemon keeps its clean user environment but now preserves only the launching CLI PATH, which is required to discover explicitly installed build tools. This is cross-platform and recognizes Windows' case-insensitive Path spelling. All other parent-process variables remain excluded.\n\nValidation: workflow render check and git diff --check passed. The focused binary test was attempted twice but timed out during the cold fbuild dependency compilation without a compiler or test failure.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 46 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 391d3cef-23bf-4348-9db2-e464c1b39ea3

📥 Commits

Reviewing files that changed from the base of the PR and between c2be6d1 and 60b7d2f.

📒 Files selected for processing (3)
  • .github/workflows/template_build.yml
  • crates/fbuild-cli/src/daemon_client.rs
  • crates/fbuild-cli/src/daemon_client/tests.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/daemon-inherit-tool-path

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit 29b29a9 into main Jul 25, 2026
89 of 94 checks passed
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant