Skip to content

feat(ide): generate .zed/debug.json for probe-rs targets (#1076 Phase 3 m1) - #1199

Merged
zackees merged 1 commit into
mainfrom
feat/1076-phase3-zed-debug
Jul 27, 2026
Merged

feat(ide): generate .zed/debug.json for probe-rs targets (#1076 Phase 3 m1)#1199
zackees merged 1 commit into
mainfrom
feat/1076-phase3-zed-debug

Conversation

@zackees

@zackees zackees commented Jul 27, 2026

Copy link
Copy Markdown
Member

Phase 3 milestone 1 of the corrected #1076 plan: fbuild ide now generates a Zed debugger attach configuration for probe-rs-supported targets.

  • Chip mapping (conservative, verified against fbuild's board JSON mcu strings): rp2040RP2040, rp2350RP2350, nrf52840nRF52840_xxAA, stm32f103c8(t6)STM32F103C8. Teensy 4.x (imxrt1062) deliberately unmapped pending probe-rs name verification; ESP32/AVR/OpenOCD targets are out of milestone 1 per the plan — they get a first-class one-line "debug config not supported" note and no config.
  • .zed/debug.json: "fbuild: Debug (probe-rs attach)" entry with adapter: probe-rs, request: attach, tcp_connection: {127.0.0.1, 50101}, program pointing at the env's ELF. Merge-don't-clobber with the same "fbuild: " label-ownership convention as tasks.json. Zed's docs don't formally spec tcp_connection's inner fields — the shape follows Zed's known TCP-adapter convention and is flagged as best-effort in code comments.
  • .zed/tasks.json gains "fbuild: Debug server (probe-rs)" (probe-rs dap-server --port 50101 --chip <CHIP>) only when a chip resolves; probe-rs is the user's install (fbuild does not install it in milestone 1).

Validation (local)

  • soldr cargo test -p fbuild-cli → 241 passed (16 new); clippy -D warnings clean; fmt clean; full bash test before merge.
  • One transient failure in unrelated port_scan tests reproduced as pre-existing parallel-test flakiness (passes in isolation and on rerun); not caused by this change.

Part of #1076 (Phase 3 milestone 1).

🤖 Generated with Claude Code

… 3 m1)

- New ide_debug module: conservative mcu -> probe-rs chip mapping
  (RP2040, RP2350, nRF52840_xxAA, STM32F103C8; unknown => None),
  merge-don't-clobber .zed/debug.json emitter ("fbuild: " label
  ownership), and a companion "fbuild: Debug server (probe-rs)" task
  (probe-rs dap-server --port 50101 --chip <CHIP>) added only when a
  chip resolves.
- Unsupported targets get a first-class one-line note and no config;
  OpenOCD/ESP32/AVR are explicitly out of milestone 1 per the plan.
- MCU resolution reuses the deploy path's board-config pattern.

Part of #1076 (Phase 3 milestone 1).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 19 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 88bbd5f4-e4c5-4be1-aa2a-3f3af2f6b7fe

📥 Commits

Reviewing files that changed from the base of the PR and between 2218e3d and 68f74cc.

📒 Files selected for processing (5)
  • agents/docs/commands-reference.md
  • crates/fbuild-cli/src/cli/ide.rs
  • crates/fbuild-cli/src/cli/ide_debug.rs
  • crates/fbuild-cli/src/cli/mod.rs
  • docs/reference/cli.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/1076-phase3-zed-debug

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit f7c4be9 into main Jul 27, 2026
87 of 93 checks passed
@zackees
zackees deleted the feat/1076-phase3-zed-debug branch July 27, 2026 20:45
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant