Skip to content

fix(ide): correct probe-rs chip names; map Teensy 4.x (#1076) - #1203

Merged
zackees merged 1 commit into
mainfrom
fix/1076-probe-rs-chip-names
Jul 28, 2026
Merged

fix(ide): correct probe-rs chip names; map Teensy 4.x (#1076)#1203
zackees merged 1 commit into
mainfrom
fix/1076-probe-rs-chip-names

Conversation

@zackees

@zackees zackees commented Jul 28, 2026

Copy link
Copy Markdown
Member

Chip-table follow-up for #1199, with names verified directly against probe-rs/probe-rs master probe-rs/targets/:

  • rp2350RP235x (was RP2350, which probe-rs does not define — the ARM-core chip entry in RP235x.yaml is RP235x; the shipped name would have failed probe-rs dap-server --chip RP2350).
  • imxrt1062MIMXRT1060 (new mapping; MIMXRT1060.yaml's single chip entry covers the 1061/1062 used by Teensy 4.x — previously deliberately unmapped pending exactly this verification. Teensy boards still need debug pads wired to a probe; the generated config is correct when they are).
  • STM32F103C8 confirmed against STM32F1_Series.yaml per-part naming; nRF52840_xxAA unchanged.

Docs updated. soldr cargo test -p fbuild-cli → 249 passed; clippy -D warnings clean.

Part of #1076 (Phase 3 chip-table expansion).

🤖 Generated with Claude Code

Verified against probe-rs/probe-rs master target files:
- rp2350 -> RP235x (was RP2350, which probe-rs does not define; the
  ARM-core chip entry in RP235x.yaml is named RP235x)
- imxrt1062 -> MIMXRT1060 (new; MIMXRT1060.yaml's single chip entry
  covers the 1061/1062 parts used by Teensy 4.x)
- STM32F103C8 confirmed against STM32F1_Series.yaml per-part naming.

Part of #1076 (Phase 3 chip-table expansion).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 48 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5b9e6f9a-cf29-4bb5-b907-e5fcf77312f4

📥 Commits

Reviewing files that changed from the base of the PR and between ff08029 and d06a06c.

📒 Files selected for processing (2)
  • crates/fbuild-cli/src/cli/ide_debug.rs
  • docs/reference/cli.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/1076-probe-rs-chip-names

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit 26989c9 into main Jul 28, 2026
87 of 93 checks passed
@zackees
zackees deleted the fix/1076-probe-rs-chip-names branch July 28, 2026 00:44
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant