fix: use trailing-slash links for index pages so sidebar active state works properly - #340
Merged
Merged
Conversation
Carl Kittelberger (icedream)
marked this pull request as draft
July 31, 2026 15:02
Carl Kittelberger (icedream)
marked this pull request as ready for review
July 31, 2026 15:03
Carl Kittelberger (icedream)
marked this pull request as draft
July 31, 2026 15:18
Carl Kittelberger (icedream)
force-pushed
the
fix/sidebar-active-index
branch
from
July 31, 2026 15:21
37acb9f to
00b7f90
Compare
Carl Kittelberger (icedream)
marked this pull request as ready for review
July 31, 2026 15:22
Alex Bartolomey (zoomoid)
approved these changes
Aug 3, 2026
Brendan Le Glaunec (Ullaakut)
approved these changes
Aug 3, 2026
… works properly - sidebar: /token-service/index → /token-service/ (VitePress serves index.md at /token-service/) - sidebar: /hathora/index → /hathora/ - docs: update remaining links to use canonical trailing-slash form
Carl Kittelberger (icedream)
force-pushed
the
fix/sidebar-active-index
branch
from
August 4, 2026 07:53
00b7f90 to
61d60c8
Compare
Copilot started reviewing on behalf of
Carl Kittelberger (icedream)
August 4, 2026 07:53
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes VitePress sidebar active-state matching for section index pages by switching sidebar (and related in-text) links from /.../index to the directory’s trailing-slash route (/.../), which is the path VitePress serves for index.md.
Changes:
- Updated
sidebar.jsonentries to use trailing-slash links for index pages in the Token Service and Hathora sections. - Updated Markdown cross-references to the Token Service overview page to use the new canonical route.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/steelshield/unreal-engine-plugin/introduction.md | Updates the Token Service link to the trailing-slash index route. |
| src/steelshield/token-service/sidebar.json | Changes the Token Service overview sidebar link to /token-service/ for correct active-state matching. |
| src/multiplayer-servers/hathora/sidebar.json | Changes the Hathora migration guide sidebar link to /hathora/ for correct active-state matching. |
| src/multiplayer-servers/getting-started/glossary.md | Updates the Token Service overview link to the trailing-slash index route. |
Hauke Löffler (hloeffler)
temporarily deployed
to
github-pages
August 4, 2026 09:58 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For index pages served at
/folder/, the sidebar navigation couldn't mark the entry as active.Root cause: VitePress serves
index.mdat the directory's trailing-slash path (/folder/), not at/folder/index. The sidebar links were written as/folder/index, which never matched the current route/folder/, so the active state was never triggered.Fix
Changed the sidebar link from
/token-service/index→/token-service/(and the same for/hathora/). Now the sidebar link matches the actual URL, and the active state works as expected.Affected sections
src/steelshield/token-service/sidebar.jsonsrc/multiplayer-servers/hathora/sidebar.jsonTesting
Build of docs still works
In the browser the active indication of pages in the sidebar now works visibly: