Skip to content

feat(refactor): Add extraparams parameter to all gameservers - #2120

Closed
borzaka wants to merge 27 commits into
GameServerManagers:developfrom
borzaka:add-extraparams-parameter
Closed

borzaka wants to merge 27 commits into
GameServerManagers:developfrom
borzaka:add-extraparams-parameter

Conversation

@borzaka

@borzaka borzaka commented Dec 15, 2018 •

Copy link
Copy Markdown
Contributor

Description

Now you can easily add any extra parameter to your gameserver without copying and modifying the whole fn_params() in your instance.cfg

Fixes #2183

Type of change

  • Bug fix (non breaking change which fixes an issue)
  • New feature (non breaking change which adds functionality)
  • Refactor (non breaking change restructures existing code)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • This pull request links to an issue
  • I have performed a self review of my own code
  • I have commented my code, particularly in hard to understand areas
  • I have made corresponding changes to the documentation

Now you can easily add any extra parameter to your gameserver without copying and modifying the whole fn_params() in your instance.cfg
@Frisasky

Copy link
Copy Markdown
Contributor

i have synced the PR with latest develop codebase, it should be ready for testing

@Frisasky
Frisasky requested a review from dgibbs64 July 11, 2019 00:45
@borzaka

borzaka commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

Hi @dgibbs64,

I've revived this feature in a new PR: #4970

  • Rebased onto the current develop and squashed into a single commit.
  • extraparams is now added to all 141 game server configs, including servers added since this PR was opened.
  • It's placed consistently: the last entry of the "Predefined Parameters" block, and every startparameters ends with ${extraparams}. The default is empty, so there's no behaviour change unless a user sets it.
  • Fixes Extra Parameters Option #2183. @Frisasky is kept as a co-author for the original work.

borzaka added a commit to borzaka/LinuxGSM that referenced this pull request Oct 5, 2026
Add an `extraparams` variable to every game server's _default.cfg so users can append custom start parameters from their instance.cfg without copying and overriding the whole `startparameters` line.

`extraparams=""` is the last entry of the "Predefined Parameters" block in every config, and every `startparameters` ends with `${extraparams}`.

Supersedes GameServerManagers#2120.

Co-authored-by: Frisasky <digimoncn@gmail.com>
borzaka added a commit to borzaka/LinuxGSM that referenced this pull request Oct 10, 2026
Add an `extraparams` variable to every game server's _default.cfg so users can append custom start parameters from their instance.cfg without copying and overriding the whole `startparameters` line.

`extraparams=""` is the last entry of the "Predefined Parameters" block in every config, and every `startparameters` ends with `${extraparams}`.

Supersedes GameServerManagers#2120.

Co-authored-by: Frisasky <digimoncn@gmail.com>
borzaka added a commit to borzaka/LinuxGSM that referenced this pull request Oct 10, 2026
Add an `extraparams` variable to every game server's _default.cfg so users can append custom start parameters from their instance.cfg without copying and overriding the whole `startparameters` line.

`extraparams=""` is the last entry of the "Predefined Parameters" block in every config, and every `startparameters` ends with `${extraparams}`.

Supersedes GameServerManagers#2120.

Co-authored-by: Frisasky <digimoncn@gmail.com>
borzaka added a commit to borzaka/LinuxGSM that referenced this pull request Oct 11, 2026
Add an `extraparams` variable to every game server's _default.cfg so users can append custom start parameters from their instance.cfg without copying and overriding the whole `startparameters` line.

`extraparams=""` is the last entry of the "Predefined Parameters" block in every config, and every `startparameters` ends with `${extraparams}`.

Supersedes GameServerManagers#2120.

Co-authored-by: Frisasky <digimoncn@gmail.com>
borzaka added a commit to borzaka/LinuxGSM that referenced this pull request Oct 11, 2026
Add an `extraparams` variable to every game server's _default.cfg so users can append custom start parameters from their instance.cfg without copying and overriding the whole `startparameters` line.

`extraparams=""` is the last entry of the "Predefined Parameters" block in every config, and every `startparameters` ends with `${extraparams}`.

Supersedes GameServerManagers#2120.

Co-authored-by: Frisasky <digimoncn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch conflicts Branch of pr has conflicts that need to be worked on type: refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants