Repository navigation
Conversation
This was referenced Oct 3, 2026
borzaka
force-pushed
the
feat/add-extraparams
branch
3 times, most recently
from
October 10, 2026 21:09
0e6d46d to
5b75f25
Compare
borzaka
force-pushed
the
feat/add-extraparams
branch
from
October 11, 2026 07:29
5b75f25 to
8dbe659
Compare
Add an `extraparams` variable to every game server's _default.cfg so users can append custom start parameters from their instance.cfg without copying and overriding the whole `startparameters` line.
`extraparams=""` is the last entry of the "Predefined Parameters" block in every config, and every `startparameters` ends with `${extraparams}`.
Supersedes GameServerManagers#2120.
Co-authored-by: Frisasky <digimoncn@gmail.com>
borzaka
force-pushed
the
feat/add-extraparams
branch
from
October 11, 2026 16:45
8dbe659 to
57ad717
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an
extraparamsvariable to every game server's_default.cfgand appends it to the end ofstartparameters.Users can now add their own start parameters in
instance.cfg(orcommon.cfg) without copying and overriding the wholestartparametersline. They also keep getting future upstream changes to the default parameters.Details:
extraparams=""is the last entry of the## Predefined Parametersblock in all 143 server configs. Configs that had no such block got one.startparametersnow ends with${extraparams}. The default is empty, so nothing changes unless the user sets it.startparameterslines (hcuserver,kfserver) include it too.kf2server:${extraparams}sits inside the escaped quotes, next to-QueryPort, which is also inside them.This revives #2120 (first opened in 2018 as #2084) on top of the current
developbranch, squashed into a single commit. The original implementation was co-authored by @Frisasky.Fixes #2183
Supersedes #2120
Type of change
Testing
Please list the exact validation you performed and the outcome.
bash -non all 143_default.cfgfiles.fn_reload_startparameters()for every config. Each test sourced_default.cfg, setextraparams="-lgsmtest a -lgsmtest2 b"the way an instance config would, and re-evaluated thestartparametersline the same waylinuxgsm.shdoes (eval startparameters="$(sed -nr 's/^ *startparameters=(.*)$/\1/p' ...)").developto confirm thatstartparametersis unchanged apart from the appended${extraparams}.git diff --check.bash -n: no syntax errors.extraparamsis empty in all configs.develop: 143/143 changed only by the appended${extraparams}.git diff --check: no whitespace issues.Risk and rollback
startparametersonly gains a trailing space, which shell word splitting drops. The one exception iskf2server, where the space lands inside the quoted argument.startparametersin their instance config are not affected.Breaking changes
Documentation impact
The start parameters page (https://docs.linuxgsm.com/configuration/start-parameters) should describe
extraparams.Checklist
PR will not be merged until all steps are complete.
Documentation
If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.
Thank you for your Pull Request!
🤖 Generated with Claude Code