feat(hygon): enable RCCL collectives - #71
Closed
gongchensu wants to merge 1 commit into
Closed
Conversation
Reuse the NCCL-compatible collective implementation with DTK RCCL on Hygon devices. Select the native RCCL header to avoid CUDA/HIP type conflicts and register Hygon as a supported backend-device combination.
Collaborator
|
This PR is closed due to duplicate work. HYGON RCCL has been supported in #74. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse the NCCL-compatible collective implementation with DTK RCCL on Hygon devices. Select the native RCCL header to avoid CUDA/HIP type conflicts and register Hygon as a supported backend-device combination.
Summary
Enable Hygon DCUs to use InfiniCCL's existing NCCL-compatible collective backend through DTK RCCL. This PR registers the
kNccl/kHygoncombination, selects native RCCL headers for Hygon builds to avoid CUDA/HIP type conflicts, and documents the supported configuration.Hygon backend integration
BackendType::kNcclwithDevice::Type::kHygon.CclApispecialization that reuses the existing NCCL-compatible collective implementation.NCCL/RCCL compatibility
<rccl/rccl.h>for Hygon builds and retain<nccl.h>for NVIDIA and Iluvatar builds.Build and documentation
WITH_HYGON=ONto be combined withWITH_NCCL=ONand linked against DTK RCCL.README.md.Platform and Backend Affected
Platform
Backend
Performance Impact
If applicable, provide benchmark results.
Known Issues & Future Work
Test Results
Test Involved Platform
Test Involved Backend
Checklist
Title, Branch, and Commits
feat: …,fix(nccl): …).<type>/xxx-yyyy-zzzzwhere<type>matches the PR title's Conventional Commits type and words are joined with hyphens (seeCONTRIBUTING.md§Branches).CONTRIBUTING.md§Pull Requests).master— the branch is rebased cleanly on top of the currentmaster.fixup!/squash!/wipcommits remain.Scope and Design
CONTRIBUTING.md§Code/General).printf/std::cout/print(...)left behind, orTODOwithout an owner and issue link.General Code Hygiene
CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).the `AllReduce` implementation) (CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General; §Python).C++ Specific (if C++ files changed)
clang-format(version 16, per.github/workflows/clang-format.yml) has been run against all modified applicable files; the diff is clean.assertwith messages that include at least__FILE__,__LINE__, and__func__(CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).Python Specific (if Python files changed)
ruff checkpasses cleanly on CI (see.github/workflows/ruff.yml).ruff format --checkpasses cleanly — if not, runruff formatand commit the result.CONTRIBUTING.md§Python).pytest.skipmessages without terminal period) are honored where applicable (CONTRIBUTING.md§Python).CONTRIBUTING.md§Python).if,for, and similar control-flow statements (CONTRIBUTING.md§Python).return, except when it directly follows a control-flow statement (CONTRIBUTING.md§Python).CONTRIBUTING.md§Python).Testing
Build, CI, and Tooling
CMakeLists.txtunderif(AUTO_DETECT_DEVICES)or toif(AUTO_DETECT_BACKENDS)if applicable.clang-format.yml,ruff.yml) are green locally (or expected to be green on CI).Documentation
README.md,CONTRIBUTING.md, or inline docs updated when behavior, build flags, or developer workflow changed.!orBREAKING CHANGE:footer.Security and Safety