feat: support HYGON RCCL - #74
Merged
Merged
Conversation
- add HYGON RCCL API traits and enable the NCCL/HYGON combination - use `NcclDataTypeTraits` to make NCCL datatype mappings device-specific for BF16 support - propagate RCCL compatibility definitions to library and example targets
…/comm_instance.h` to avoid warning
…dicate RCCL supportiveness
66 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds HYGON RCCL support by reusing InfiniCCL's existing NCCL backend.
CMakeLists.txtdetects HYGON RCCL headers and libraries from the DTK/ROCm environment, whilesrc/backends/ccl/nccl/compat.hselects the NCCL-compatible vendor header. Device-specific datatype traits preserve the existing NVIDIA and Iluvatar behavior and add HYGON BF16 capability handling.Changes
Build and Dependency Detection
/opt/dtklocations, and smi program;INFINI_CCL_USE_RCCLto the InfiniCCL library and examples.NCCL-family Backend Integration
src/backends/ccl/nccl/compat.h;CclApispecialization and enable the NCCL/HYGON backend combination;NcclDataTypeTraitsso support can vary by device platform;RCCL_BFLOAT16for HYGON.Documentation Update
README.mdand then PR template to show RCCL support.Platform and Backend Affected
Platform
Backend
Performance Impact
N/A. This PR adds RCCL backend support and does not change the collective algorithms or communication data path used by existing platforms.
Known Issues & Future Work
N/A.
Test Results
Test Involved Platform
Test Involved Backend
HYGON RCCL (single BW1000 node):
ccl_all_reduce.log
HYGON RCCL + OMPI (2 HYGON BW1000 nodes):
ccl_mpi_hybrid_all_reduce.log
Iluvatar NCCL + OMPI (single BI-150 node):
ccl_mpi_hybrid_all_reduce.log
NVIDIA NCCL + OMPI (single A100 node):
ccl_mpi_hybrid_all_reduce.log
Checklist
Title, Branch, and Commits
feat: …,fix(nccl): …).<type>/xxx-yyyy-zzzzwhere<type>matches the PR title's Conventional Commits type and words are joined with hyphens (seeCONTRIBUTING.md§Branches).CONTRIBUTING.md§Pull Requests).master— the branch is rebased cleanly on top of the currentmaster.fixup!/squash!/wipcommits remain.Scope and Design
CONTRIBUTING.md§Code/General).printf/std::cout/print(...)left behind, orTODOwithout an owner and issue link.General Code Hygiene
CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).the `AllReduce` implementation) (CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General; §Python).C++ Specific (if C++ files changed)
clang-format(version 16, per.github/workflows/clang-format.yml) has been run against all modified applicable files; the diff is clean.assertwith messages that include at least__FILE__,__LINE__, and__func__(CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).Python Specific (if Python files changed)
Testing
Build, CI, and Tooling
CMakeLists.txtunderif(AUTO_DETECT_DEVICES)or toif(AUTO_DETECT_BACKENDS)if applicable.clang-format.yml,ruff.yml) are green locally (or expected to be green on CI).Documentation
README.md,CONTRIBUTING.md, or inline docs updated when behavior, build flags, or developer workflow changed.!orBREAKING CHANGE:footer.Security and Safety