Fix use-after-scope in RandomX job thread task lambda#2
Merged
MoneroOcean merged 2 commits intoMay 27, 2026
Merged
Conversation
MoneroOcean
deleted the
codex/fix-use-after-scope-vulnerability-in-randomx
branch
May 27, 2026 17:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
std::atomic<int> unique_counterwas captured by reference in thread-pool tasks and could be accessed afterset_job()returned.thread_idvalues that were then used to indexnew_inputsandm_vm, risking crashes or native memory corruption.Description
unique_counterfromCore::set_job()to eliminate the dangling reference risk.int thread_idparameter supplied byctpl::thread_pooland stop capturing the counter.Testing
rgto confirmunique_counteris no longer referenced andrx_thread_idusage remains consistent, and the searches succeeded.sed -n '300,350p' moner-job.cppandnl -ba moner-job.cpp | sed -n '330,360p'to verify the lambda signature and captures were updated as intended.Codex Task