Skip to content

Fix use-after-scope in RandomX job thread task lambda #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MoneroOcean merged 2 commits into from
May 27, 2026
Merged

Fix use-after-scope in RandomX job thread task lambda #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e958fcf
Fix RandomX set_job thread_id lifetime bug
MoneroOcean May 27, 2026
545dc66
Merge branch 'main' into codex/fix-use-after-scope-vulnerability-in-r…
MoneroOcean May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions moner-job.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,10 +346,8 @@ void Core::set_job(
// start rx job compute threads
if (new_dev == DEV::RX_CPU) {
const unsigned job_ref = m_job_ref;
std::atomic<int> unique_counter{0};
for (unsigned batch_id = 0; batch_id != m_batch; ++batch_id) m_thread_pool->push(
[=, &m_job_ref = m_job_ref, &m_hash_count = m_hash_count, &unique_counter, new_inputs, new_input_hexes](int) {
const int thread_id = unique_counter.fetch_add(1);
[=, &m_job_ref = m_job_ref, &m_hash_count = m_hash_count, new_inputs, new_input_hexes](int thread_id) {
try {
alignas(16) uint8_t input[MAX_BLOB_LEN];
alignas(16) uint8_t output[HASH_LEN];
Expand Down