Repository navigation
Conversation
There was a problem hiding this comment.
🤖 NCode Review at d52b787: 2 new findings on the changed lines.
|
Superseded by the review at 5d49e7e. |
Contributor
Author
|
/review |
🤖 Review completeVerdict: ✅ Approve — Re-review of what changed since the last review at d52b787: 1 hunk in 1 file, by correctness only. Earlier findings: F1 fixed. No further findings above nits. 1 reviewer run — 0 findings (run details)
Trial: findings are posted as review threads and in the check run. $0.03 on Amazon Bedrock, 8s, at 5d49e7e. (how to interact) 📋 OutcomesMerged at 5d49e7e: 1 fixed, 1 dismissed, 0 acknowledged, 0 ignored.
|
polewskm
marked this pull request as ready for review
October 31, 2026 22:02
This was referenced Oct 31, 2026
Closed
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins two behaviors that only
main()held, so tests now reach them, with no behavior or log text changed:tallyCaseinevals/run.ts, with tests that review cost leaves out the concern and precision judges' calls while the case cost counts them.writeForPublishmoves verbatim tosrc/outputs.ts, and the explain answer's writing moves intowriteAnswerinsrc/explain.ts, with tests that an unknown finding writes onlyanswer.jsonwithout a model call,trace.jsonis written when the call ran,answeredis set, andresults.jsonis never written.mainin to resolve aCHANGELOG.mdconflict, so merge this with a merge commit, not by rebasing.Closes #107
Closes #108
A first review round tested that
writeAnswerrefuses a secret in the answer or trace; main is merged in after #104.