Skip to content

Eval results, smoke baseline, outcome replies and v1.0.0 - #142

Merged
polewskm merged 9 commits into
mainfrom
issue-123
Nov 1, 2026
Merged

polewskm merged 9 commits into
mainfrom
issue-123

Conversation

@polewskm

@polewskm polewskm commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

This PR acts on the 2026-11-01 evals (9 runs through the Eval and Smoke eval workflows, $24.83 in total) and prepares v1.0.0:

Closes #41
Closes #123
Closes #135
Refs #52
Refs #97
Refs #57

@polewskm
polewskm deployed to code-review November 1, 2026 07:10 — with GitHub Actions Active

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at 95d23d5: 5 new findings on the changed lines.

Comment thread README.md Resolved
Comment thread src/config.ts Resolved
Comment thread test/verify.test.ts Resolved
Comment thread test/outcomes.test.ts Resolved
Comment thread src/config.ts Resolved
@ncode-review

ncode-review Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Superseded by the review at 035aa01.

@polewskm

polewskm commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

/review

@ncode-review

ncode-review Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

🤖 Review complete

Verdict: ✅ Approve — Re-review of what changed since the last review at 95d23d5: 6 hunks in 6 files and changes taken back in 3 files, by correctness only. Earlier findings: F1 fixed, F2 fixed, F3 fixed, F4 fixed, F5 still open. No further findings above nits.

1 reviewer run — 0 findings (run details)

Reviewer Model Findings Top
correctness sonnet-5-5 0 🟢

Trial: findings are posted as review threads and in the check run. $0.04 on Amazon Bedrock, 10s, at 035aa01. (how to interact)

📋 Outcomes

Merged at 035aa01: 2 fixed, 3 dismissed, 0 acknowledged, 0 ignored.

Finding Reviewer Severity Outcome
F1 rule-check 🟡 Nit ✅ fixed
F2 rule-check 🟡 Nit ✅ fixed
F3 tests 🟡 Nit 👎 dismissed
F4 tests 🟡 Nit 👎 dismissed
F5 hygiene 🟡 Nit 👎 dismissed

@polewskm
polewskm marked this pull request as ready for review November 1, 2026 07:24
@polewskm
polewskm deployed to code-review November 1, 2026 07:24 — with GitHub Actions Active
@polewskm
polewskm merged commit d14405f into main Nov 1, 2026
8 checks passed
@polewskm
polewskm deleted the issue-123 branch November 1, 2026 07:25

This branch was successfully deployed

1 active deployment
code-review — 035aa010 Deployed Nov 1, 2026 by polewskm via review #460
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant