Skip to content

Dispatchable evals, synthesis knobs and the decisions rule - #140

Merged
polewskm merged 7 commits into
mainfrom
eval-knobs
Nov 1, 2026
Merged

polewskm merged 7 commits into
mainfrom
eval-knobs

Conversation

@polewskm

@polewskm polewskm commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

This PR adds the means to run the remaining evals without a local Bedrock key and fixes the smoke eval's must-not failure on main:

Closes #122
Refs #52
Refs #123
Refs #135
Refs #41
Refs #57

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at af9d1c5: 3 new findings on the changed lines.

Comment thread src/config.ts Resolved
Comment thread src/config.ts Resolved
Comment thread src/config.ts Resolved
@ncode-review

ncode-review Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Superseded by the review at 43eef8c.

…levels in one list, write issue references as issue #N
@polewskm

polewskm commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

/review

@ncode-review

ncode-review Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

🤖 Review complete

Verdict: ✅ Approve — Re-review of what changed since the last review at af9d1c5: 8 hunks in 5 files and changes taken back in 4 files, by correctness only. Earlier findings: F1 fixed, F2 fixed, F3 fixed. No further findings above nits.

1 reviewer run — 0 findings (run details)

Reviewer Model Findings Top
correctness sonnet-5-5 0 🟢

Trial: findings are posted as review threads and in the check run. $0.05 on Amazon Bedrock, 11s, at 43eef8c. (how to interact)

📋 Outcomes

Merged at 43eef8c: 2 fixed, 1 dismissed, 0 acknowledged, 0 ignored.

Finding Reviewer Severity Outcome
F1 rule-check 🟠 Should fix 👎 dismissed
F2 hygiene 🟡 Nit ✅ fixed
F3 rule-check 🟡 Nit ✅ fixed

@polewskm
polewskm marked this pull request as ready for review November 1, 2026 05:46
@polewskm
polewskm deployed to code-review November 1, 2026 05:46 — with GitHub Actions Active
@polewskm
polewskm enabled auto-merge November 1, 2026 05:46
@polewskm
polewskm merged commit f9f8d1d into main Nov 1, 2026
8 checks passed
@polewskm
polewskm deleted the eval-knobs branch November 1, 2026 05:47

This branch was successfully deployed

1 active deployment
code-review — 43eef8c8 Deployed Nov 1, 2026 by polewskm via review #451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parse C# with a real grammar

1 participant