Repository navigation
Conversation
Findings carry an optional suggestion that placeFindings attaches only when every line it replaces is added by the pull request and the comment stays on the finding's line; the comment then covers the range. The hidden marker names the reviewers, and older markers still parse and dedupe.
There was a problem hiding this comment.
🤖 NCode Review at 0ce9bf6: 8 new findings on the changed lines.
🤖 Review completeVerdict: 💬 Comment — This PR adds an optional 8 reviewers run — 4 findings (run details)
Skipped: api-compat, infrastructure, intent, performance, tests Findings
Trial: findings are posted as review threads and in the check run. $0.46 on Amazon Bedrock, 60s, at 6c9d1b8. (how to interact) |
…prompt's limit, one behavior per test Each rejection branch of usableSuggestion gets its own test, as do the delete suggestion, line-ending normalization, marker spoofing and reviewer parsing. The output schemas are exported so a test can check suggestion stays optional, and a test ties the specialist prompt's line limit to maxSuggestionLines. The reviewers field comment no longer leans on marker history.
|
/review |
There was a problem hiding this comment.
🤖 NCode Review at 892f0c3: 4 new findings on the changed lines.
|
Autopilot: Round 2 answered. No blocker or should-fix is left open; the remaining threads are nits, answered above. Recommend merging once you've resolved them. |
There was a problem hiding this comment.
🤖 NCode Review at 6c9d1b8: 3 new findings on the changed lines.
1 more was already posted on this pull request.
# Conflicts: # CHANGELOG.md # prompts/synthesis.md # src/publish.ts
# Conflicts: # CHANGELOG.md
|
Autopilot: answering F4 ( |
|
Autopilot: Round 3 answered. The review-round limit (3) is reached; no verified blocker or should-fix showing a defect in this PR's behavior is left open. The repeated security finding is declined as a design choice of #54 (a generated-suggestion note could be a follow-up issue), and the remaining threads are nits, answered above. The branch is up to date with |
Findings get an optional
suggestion: { startLine, endLine, replacement }. Specialists fill it only for a mechanical fix of 5 lines or fewer, and synthesis keeps it unchanged when it merges.placeFindingsattaches it only when every line in the range is added by the pull request, the range holds the finding's line, and the comment wasn't snapped. The comment then spansstart_line/linewith a```suggestionblock, and the fence is longer than any run of backticks in the code. Otherwise the prose fix stands alone. The hidden marker gainsreviewer=<names>.parsePostedreads the last marker in a comment, so an older comment without the field still parses and dedupes.Decisions
lineonly. GitHub requiresstart_line<line.Not verified: applying a suggestion on a real pull request on GitHub, which this environment can't do, including GitHub's handling of a fence longer than three backticks.
Closes #54