[luyiyun1021]

@coderabbitai summary

Description

Remove the four test_fp4_gemm_bias_per_backend[mnk2/mnk3-cublaslt/cutlass] waivers for https://nvbugs/6581067. #17505 fixed the parity reference (single rounding) and removed these waivers; #18232 added them back, so the fixed cases are skipped on main.

Test Coverage

unittest/_torch/thop/parallel/test_fp4_linear.py::test_fp4_gemm_bias_per_backend[mnk2/mnk3-cublaslt/cutlass] run in CI without the waivers; not run locally.

PR Checklist

• PR description clearly explains what and why.

• PR Follows TRT-LLM CODING GUIDELINES.

• Test cases are provided for new code paths.

• Any new dependencies have been scanned for license and vulnerabilities.

• CODEOWNERS updated if ownership changes.

• Documentation updated as needed.

• Update tava architecture diagram if significant design change.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

[luyiyun1021]

/bot run --disable-fail-fast

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: NVIDIA/TensorRT-LLM/.coderabbit.yaml
• Review profile: CHILL
• Plan: Enterprise
• Run ID: f80ca05d-1e25-4214-b183-e72d99b3454f

📥 Commits

Reviewing files that changed from the base of the PR and between 0372799 and d8c2c88.

📒 Files selected for processing: 1

• tests/integration/test_lists/waives.txt

💤 Files with no reviewable changes: 1

• tests/integration/test_lists/waives.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

⚠️ A high-level summary could not be generated for this review. CodeRabbit will regenerate it on the next update, or you can request a refresh with @coderabbitai summary.

Walkthrough

The integration test waiver list no longer skips four FP4 GEMM bias tests: the mnk2 and mnk3 cases for the cublaslt and cutlass backends.

Changes

FP4 GEMM bias tests

Layer / File(s)	Summary
Remove FP4 GEMM bias test waivers tests/integration/test_lists/waives.txt	Removed skip waivers for the mnk2 and mnk3 FP4 GEMM bias tests on the cublaslt and cutlass backends.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to d8c2c

No actionable issue is established. The newly unwaived tests should run through normal validation.

Pre-merge checks: 5

Check name	Status	Explanation
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title follows the required ticket/type format and clearly states that the FP4 GEMM bias tests are being unwaived.
Description check		The description explains the reason for removing the waivers, identifies the affected tests, and provides test coverage and checklist details. Some checklist items are not explicitly addressed, but th…

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

Full details: Description check

Explanation

The description explains the reason for removing the waivers, identifies the affected tests, and provides test coverage and checklist details. Some checklist items are not explicitly addressed, but the description is mostly complete.

✨ Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[tensorrt-cicd]

PR_Github #78827 [ run ] triggered by Bot. Commit: d8c2c88 Link to invocation

[luyiyun1021]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #78830 [ run ] triggered by Bot. Commit: 44d7a63 Link to invocation

[tensorrt-cicd]

PR_Github #78827 [ run ] completed with state ABORTED. Commit: d8c2c88

Link to invocation

[tensorrt-cicd]

PR_Github #78830 [ run ] completed with state SUCCESS. Commit: 44d7a63
/LLM/main/L0_MergeRequest_PR pipeline #64950 completed with status: 'SUCCESS'

CI Report

Link to invocation

[brnguyen2]

Approving — the comments below are optional touch-ups, not blockers.

Two things before merge:

1. The description says #18232 re-added these waivers but not why. If #18232 added them back because of a new GB10 failure after the reference fix (rather than a stale waive-list merge), removing them now would bring that failure back. Please state which case it was.
2. These cases fail on GB10 in the post-merge stage, so the default pre-merge /bot run won't run them. Run /bot run --extra-stage "GB10-PyTorch-Post-Merge-1" (or whichever GB10 post-merge stage carries test_fp4_linear.py) and link the green result here.

[github-actions]

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

[luyiyun1021]

/bot run --extra-stage "GB10-PyTorch-Post-Merge-1"

[tensorrt-cicd]

PR_Github #79129 [ run ] triggered by Bot. Commit: 44d7a63 Link to invocation

[tensorrt-cicd]

PR_Github #79129 [ run ] completed with state SUCCESS. Commit: 44d7a63
/LLM/main/L0_MergeRequest_PR pipeline #65181 completed with status: 'SUCCESS'

CI Report

Link to invocation