Skip to content

[None][infra] Waive 3 failed cases for main in pre-merge 66510 - #21110

Merged
YihuiLu512 merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20261027-124213
Oct 27, 2026
Merged

YihuiLu512 merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20261027-124213

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @YihuiLu512)
Target branch: main
Bug(s): 6991647

Waive entries added

unittest/_torch/attention/multi_gpu/test_mha_helix.py::test_mha_helix_distributed[nccl-scenario: Scenario(dtype=torch.bfloat16, kv_cache_dtype=torch.bfloat16, num_layers=1, num_heads=16, num_kv_heads=4, head_dim=128, hidden_size=2048, rope_theta=10000.0, kv_cache_tokens_per_block=32, bias=False, batch=1, ctx_len=4096, atol=0.1, rtol=0.05)] SKIP (https://nvbugs/6991647)
unittest/_torch/attention/multi_gpu/test_mha_helix.py::test_mha_helix_distributed[nccl-scenario: Scenario(dtype=torch.bfloat16, kv_cache_dtype=torch.bfloat16, num_layers=1, num_heads=16, num_kv_heads=4, head_dim=128, hidden_size=2048, rope_theta=10000.0, kv_cache_tokens_per_block=32, bias=False, batch=1, ctx_len=512, atol=0.1, rtol=0.05)] SKIP (https://nvbugs/6991647)
unittest/_torch/attention/multi_gpu/test_mha_helix.py::test_mha_helix_distributed[nccl-scenario: Scenario(dtype=torch.bfloat16, kv_cache_dtype=torch.bfloat16, num_layers=1, num_heads=16, num_kv_heads=4, head_dim=128, hidden_size=2048, rope_theta=10000.0, kv_cache_tokens_per_block=32, bias=False, batch=1, ctx_len=64, atol=0.1, rtol=0.05)] SKIP (https://nvbugs/6991647)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Dev Engineer Review

The waiver list skips three NCCL test_mha_helix_distributed cases for bfloat16 data and KV cache, with context lengths 4096, 512, and 64. Each entry links to nvbugs/6991647. No source-code or API changes are reported.

QA Engineer Review

Only tests/integration/test_lists/waives.txt changed. It adds three case-specific SKIP waivers. The search found no matching entries in the CI test-db/ or manual-QA qa/ lists. These cases will not run while the waivers apply, so coverage needs follow-up. Coverage verdict: needs follow-up.

Per-File QA Perspective

  • tests/integration/test_lists/waives.txt: Adds waivers for the three bfloat16 NCCL context-length cases. The waivers reduce execution coverage until the tracked issue is resolved and the entries are removed.

Bug(s): 6991647
Requested by: @YihuiLu512

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@YihuiLu512

Copy link
Copy Markdown
Collaborator

/bot skip --comment "waive only PR"

@YihuiLu512
YihuiLu512 enabled auto-merge (squash) October 27, 2026 12:42
@YihuiLu512
YihuiLu512 self-requested a review October 27, 2026 12:42
@github-actions

Copy link
Copy Markdown

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between c932dd8 and b8b39c4.

Files selected for processing: 1
  • tests/integration/test_lists/waives.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

Three bfloat16 test_mha_helix_distributed NCCL scenarios, with context lengths 4096, 512, and 64, were added to the waiver list. Each is marked SKIP and tracked by nvbugs/6991647.

Changes

Helix test waivers

Layer / File(s) Summary
Add scenario waivers
tests/integration/test_lists/waives.txt
The waiver list marks the three bfloat16 scenarios with context lengths 4096, 512, and 64 as SKIP. Each entry references nvbugs/6991647.

Priority: Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Possibly related PRs

  • NVIDIA/TensorRT-LLM#20759: Both PRs concern aggregated Helix context-parallel KV-cache behavior. This PR waives MHA Helix cases; the related PR changes KVCacheManagerV2 allocation, sizing, and request handling.

Suggested reviewers: xinhe-nv, chuangz0

Merge Risk: Minimal · up to b8b39

This change only skips three known-failing distributed attention test cases, each tracked by a bug link. It does not change product behavior, so the merge risk is minimal.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title names the change: a CI infra waiver for 3 failed test cases on main in pre-merge run 66510. It follows the [None][infra] format from the template and matches the changeset, which adds three …
Description check Passed The description follows the repository's auto-generated waive PR layout. It gives the target branch (main), the bug link (nvbugs/6991647), and the three waive entries with full test IDs. It also names…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: a CI infra waiver for 3 failed test cases on main in pre-merge run 66510. It follows the [None][infra] format from the template and matches the changeset, which adds three SKIP waive entries to waives.txt. The title does not name the test file or the bug ID, but it is specific enough to identify the change.

Full details: Description check

Explanation

The description follows the repository's auto-generated waive PR layout. It gives the target branch (main), the bug link (nvbugs/6991647), and the three waive entries with full test IDs. It also names the requester. The template sections (Description, Test Coverage, PR Checklist) are absent. For a waive-only change, the bug link and waive entries cover the intent, so the gaps are minor.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #80885 [ skip ] triggered by Bot. Commit: b8b39c4 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #80885 [ skip ] completed with state SUCCESS. Commit: b8b39c4
Skipping testing for commit b8b39c4

Link to invocation

@YihuiLu512
YihuiLu512 merged commit 0d35000 into NVIDIA:main Oct 27, 2026
19 checks passed
SimengLiu-nv pushed a commit to SimengLiu-nv/TensorRT-LLM that referenced this pull request Nov 2, 2026
….3: Scope NCCL window leases in helix attention tests

Forward-port of release/1.3 PR NVIDIA#20588
(release/1.3 commit 356b1a2) to main.

Adapted to main: main never had the release-only waives for nvbugs/6932241
and 6932265, so only the helix test changes are ported. Main has since
waived the NCCL test_mha_helix_distributed cases under nvbugs/6991647
(NVIDIA#21110); those waives are kept.

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
Signed-off-by: Simeng Liu <simengl@nvidia.com>
SimengLiu-nv pushed a commit to SimengLiu-nv/TensorRT-LLM that referenced this pull request Nov 2, 2026
….3: Scope NCCL window leases in helix attention tests

Forward-port of release/1.3 PR NVIDIA#20588
(release/1.3 commit 356b1a2) to main.

Adapted to main: main never had the release-only waives for nvbugs/6932241
and 6932265, so only the helix test changes are ported. Main has since
waived the NCCL test_mha_helix_distributed cases under nvbugs/6991647
(NVIDIA#21110); those waives are kept.

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
Signed-off-by: Simeng Liu <simengl@nvidia.com>
SimengLiu-nv pushed a commit to SimengLiu-nv/TensorRT-LLM that referenced this pull request Nov 3, 2026
….3: Scope NCCL window leases in helix attention tests

Forward-port of release/1.3 PR NVIDIA#20588
(release/1.3 commit 356b1a2) to main.

Adapted to main: main never had the release-only waives for nvbugs/6932241
and 6932265, so only the helix test changes are ported. Main's waives for
the NCCL test_mha_helix_distributed cases under nvbugs/6991647 (NVIDIA#21110)
have since been removed (NVIDIA#21387), so those cases run with this change.

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
Signed-off-by: Simeng Liu <simengl@nvidia.com>
SimengLiu-nv pushed a commit to SimengLiu-nv/TensorRT-LLM that referenced this pull request Nov 3, 2026
….3: Scope NCCL window leases in helix attention tests

Forward-port of release/1.3 PR NVIDIA#20588
(release/1.3 commit 356b1a2) to main.

Adapted to main: main never had the release-only waives for nvbugs/6932241
and 6932265, so only the helix test changes are ported. Main's waives for
the NCCL test_mha_helix_distributed cases under nvbugs/6991647 (NVIDIA#21110)
have since been removed (NVIDIA#21387), so those cases run with this change.

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
Signed-off-by: Simeng Liu <simengl@nvidia.com>
SimengLiu-nv pushed a commit to SimengLiu-nv/TensorRT-LLM that referenced this pull request Nov 3, 2026
….3: Scope NCCL window leases in helix attention tests

Forward-port of release/1.3 PR NVIDIA#20588
(release/1.3 commit 356b1a2) to main.

Adapted to main: main never had the release-only waives for nvbugs/6932241
and 6932265, so only the helix test changes are ported. Main's waives for
the NCCL test_mha_helix_distributed cases under nvbugs/6991647 (NVIDIA#21110)
have since been removed (NVIDIA#21387), so those cases run with this change.

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
Signed-off-by: Simeng Liu <simengl@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants