Repository navigation
[None][infra] Waive 3 failed cases for main in pre-merge 66510 - #21110
Conversation
Bug(s): 6991647 Requested by: @YihuiLu512 Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
/bot skip --comment "waive only PR" |
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Add scenario waivers tests/integration/test_lists/waives.txt |
The waiver list marks the three bfloat16 scenarios with context lengths 4096, 512, and 64 as SKIP. Each entry references nvbugs/6991647. |
Priority:
Estimated code review effort: 2 (Simple) | ~5 minutes
Change: Other
Possibly related PRs
- NVIDIA/TensorRT-LLM#20759: Both PRs concern aggregated Helix context-parallel KV-cache behavior. This PR waives MHA Helix cases; the related PR changes
KVCacheManagerV2allocation, sizing, and request handling.
Suggested reviewers: xinhe-nv, chuangz0
Merge Risk: 
Minimal · up to b8b39
-
This change only skips three known-failing distributed attention test cases, each tracked by a bug link. It does not change product behavior, so the merge risk is minimal.
Pre-merge checks: 
5
-
Full details: Title check
-
Explanation
The title names the change: a CI infra waiver for 3 failed test cases on main in pre-merge run 66510. It follows the [None][infra] format from the template and matches the changeset, which adds three SKIP waive entries to waives.txt. The title does not name the test file or the bug ID, but it is specific enough to identify the change.
Full details: Description check
-
Explanation
The description follows the repository's auto-generated waive PR layout. It gives the target branch (main), the bug link (nvbugs/6991647), and the three waive entries with full test IDs. It also names the requester. The template sections (Description, Test Coverage, PR Checklist) are absent. For a waive-only change, the bug link and waive entries cover the intent, so the gaps are minor.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
PR_Github #80885 [ skip ] triggered by Bot. Commit: |
|
PR_Github #80885 [ skip ] completed with state |
….3: Scope NCCL window leases in helix attention tests Forward-port of release/1.3 PR NVIDIA#20588 (release/1.3 commit 356b1a2) to main. Adapted to main: main never had the release-only waives for nvbugs/6932241 and 6932265, so only the helix test changes are ported. Main has since waived the NCCL test_mha_helix_distributed cases under nvbugs/6991647 (NVIDIA#21110); those waives are kept. Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com> Signed-off-by: Simeng Liu <simengl@nvidia.com>
….3: Scope NCCL window leases in helix attention tests Forward-port of release/1.3 PR NVIDIA#20588 (release/1.3 commit 356b1a2) to main. Adapted to main: main never had the release-only waives for nvbugs/6932241 and 6932265, so only the helix test changes are ported. Main has since waived the NCCL test_mha_helix_distributed cases under nvbugs/6991647 (NVIDIA#21110); those waives are kept. Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com> Signed-off-by: Simeng Liu <simengl@nvidia.com>
….3: Scope NCCL window leases in helix attention tests Forward-port of release/1.3 PR NVIDIA#20588 (release/1.3 commit 356b1a2) to main. Adapted to main: main never had the release-only waives for nvbugs/6932241 and 6932265, so only the helix test changes are ported. Main's waives for the NCCL test_mha_helix_distributed cases under nvbugs/6991647 (NVIDIA#21110) have since been removed (NVIDIA#21387), so those cases run with this change. Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com> Signed-off-by: Simeng Liu <simengl@nvidia.com>
….3: Scope NCCL window leases in helix attention tests Forward-port of release/1.3 PR NVIDIA#20588 (release/1.3 commit 356b1a2) to main. Adapted to main: main never had the release-only waives for nvbugs/6932241 and 6932265, so only the helix test changes are ported. Main's waives for the NCCL test_mha_helix_distributed cases under nvbugs/6991647 (NVIDIA#21110) have since been removed (NVIDIA#21387), so those cases run with this change. Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com> Signed-off-by: Simeng Liu <simengl@nvidia.com>
….3: Scope NCCL window leases in helix attention tests Forward-port of release/1.3 PR NVIDIA#20588 (release/1.3 commit 356b1a2) to main. Adapted to main: main never had the release-only waives for nvbugs/6932241 and 6932265, so only the helix test changes are ported. Main's waives for the NCCL test_mha_helix_distributed cases under nvbugs/6991647 (NVIDIA#21110) have since been removed (NVIDIA#21387), so those cases run with this change. Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com> Signed-off-by: Simeng Liu <simengl@nvidia.com>
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @YihuiLu512)
Target branch:
mainBug(s): 6991647
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Dev Engineer Review
The waiver list skips three NCCL
test_mha_helix_distributedcases for bfloat16 data and KV cache, with context lengths 4096, 512, and 64. Each entry links tonvbugs/6991647. No source-code or API changes are reported.QA Engineer Review
Only
tests/integration/test_lists/waives.txtchanged. It adds three case-specificSKIPwaivers. The search found no matching entries in the CItest-db/or manual-QAqa/lists. These cases will not run while the waivers apply, so coverage needs follow-up. Coverage verdict: needs follow-up.Per-File QA Perspective
tests/integration/test_lists/waives.txt: Adds waivers for the three bfloat16 NCCL context-length cases. The waivers reduce execution coverage until the tracked issue is resolved and the entries are removed.