Repository navigation
deps: undici 7.30.1 / 8.12.3 and serialize-javascript 7.1.3 (Dependabot #73-#79) - #564
Merged
Merged
Conversation
#73-#79) Seven open Dependabot alerts on development dependencies, none shipped in the extension: undici < 7.30.1 and < 8.12.2 (two high: denial of service; an integrity bypass) through cheerio (addons-linter, webdriverio) and webdriver/geckodriver, and serialize-javascript < 7.1.3 (low, XSS) through mocha. Every parent's range allows the fix; as with #30-#42, the override floors in pnpm-workspace.yaml move up (undici@7 ^7.30.1, a new undici@8 ^8.12.2, serialize-javascript ^7.1.3). The lockfile changes only those three. Local: lint, typecheck, pnpm test (2897 passed), pnpm audit: no known vulnerabilities. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nawid3333
added a commit
that referenced
this pull request
Oct 24, 2026
An alert Dependabot cannot fix became an issue for the owner, and the fix was made by hand (#564: override floors in pnpm-workspace.yaml, the lockfile rewritten). security-alerts.yml now tries that fix itself where a floor makes it, in three jobs: - check plans the floors (tools/security-overrides.mjs: one per package and major the lockfile holds vulnerable, ^ the newest first patched version; declined, with the reason in the issue, when there is no patched version, the fix is a new major, the package is pnpm-patched, a parent-scoped or unreadable override governs it, or main has the floor already while the lockfile is still vulnerable). The alerts it takes stay out of the issues, out of both $new and $list. - install has contents: read and no token: pnpm install --lockfile-only --ignore-scripts with the floors, then verify (every alert taken fixed, every floor holding, nothing else moved). pnpm saying no version fits demotes the alerts to issues; any other failure fails the run (a report issue), never silently. - publish, the only writer, commits through the API on the planned main, keeps ONE rolling pull request on security/overrides, and starts CI and the dependency review on it. A pull request closed unmerged by hand hands its alerts back as issues; this workflow's own closes are marked closed-by-run. update-prs.yml reports on it as the kind security (only those two files, its dependency review must pass, no 3-day wait); ci.yml's hand-off covers security/. Replayed on the state before #564 with its seven alerts: the plan writes the same four floors, pnpm writes the same lockfile (the order of two keys in its overrides copy aside), verify passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nawid3333
added a commit
that referenced
this pull request
Oct 24, 2026
…uest (#571) * wip: security alerts try the override fix themselves Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * security alerts: try the override fix itself, on one rolling PR An alert Dependabot cannot fix became an issue for the owner, and the fix was made by hand (#564: override floors in pnpm-workspace.yaml, the lockfile rewritten). security-alerts.yml now tries that fix itself where a floor makes it, in three jobs: - check plans the floors (tools/security-overrides.mjs: one per package and major the lockfile holds vulnerable, ^ the newest first patched version; declined, with the reason in the issue, when there is no patched version, the fix is a new major, the package is pnpm-patched, a parent-scoped or unreadable override governs it, or main has the floor already while the lockfile is still vulnerable). The alerts it takes stay out of the issues, out of both $new and $list. - install has contents: read and no token: pnpm install --lockfile-only --ignore-scripts with the floors, then verify (every alert taken fixed, every floor holding, nothing else moved). pnpm saying no version fits demotes the alerts to issues; any other failure fails the run (a report issue), never silently. - publish, the only writer, commits through the API on the planned main, keeps ONE rolling pull request on security/overrides, and starts CI and the dependency review on it. A pull request closed unmerged by hand hands its alerts back as issues; this workflow's own closes are marked closed-by-run. update-prs.yml reports on it as the kind security (only those two files, its dependency review must pass, no 3-day wait); ci.yml's hand-off covers security/. Replayed on the state before #564 with its seven alerts: the plan writes the same four floors, pnpm writes the same lockfile (the order of two keys in its overrides copy aside), verify passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * security alerts: fixes from the final review and CodeQL - The demote step read plan.json's alerts with .[] (plan.json is an object): the first real demote would have died before raising any issue. .alerts[], and a test of the step (security-overrides- demote.test.sh) that fails with the old filter. - A deterministic install failure demotes every alert the run took (no lockfile came out, so none publishes), not only those pnpm's log named. - check and install both take the run's own commit; install no longer checks out a ref read from the artifact (CodeQL: untrusted checkout, cache poisoning) and refuses a plan made on another commit. - A run that steps aside because main moved says so in its summary. - A pull request closed by hand whose text lost its alerts marker is warned about, as its close then hands nothing back. - The no-push case compares with the branch's own tree. - The CLI dispatches through a table (CodeQL: user-controlled bypass). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The repository's Security tab showed 12 Dependabot alerts on 2026-10-24.
fast-uri) were closed by Build(deps): Bump fast-uri from 3.1.8 to 3.1.9 #563's merge.body-parser, fsaunpack's test server) is closed by Build(deps): Bump body-parser from 2.3.0 to 2.4.0 in /fsaunpack in the npm_and_yarn group across 1 directory #562.</script>)The change
Every parent's range already allows the fixed version: cheerio
^7.19.0, webdriver and geckodriver^8.11.2, mocha^7.1.1. As with #30–#42 (where pnpm kept the locked versions even onpnpm update), the override floors inpnpm-workspace.yamlmove up:undici@7to^7.30.1;undici@8: ^8.12.2;serialize-javascriptto^7.1.3.The lockfile changes only those three packages: undici 7.30.1 and 8.12.3, serialize-javascript 7.1.3.
Checked
Local:
pnpm run lint,pnpm run typecheckandpnpm test(2897 passed, 6 skipped) pass, andpnpm auditreports no known vulnerabilities. The e2e suites, which run undici through WebdriverIO and geckodriver, run on this PR's CI.🤖 Generated with Claude Code