Skip to content

fix(desktop): make workspace deletion async with toast feedback - #253

Merged
Kitenite merged 1 commit into
mainfrom
teal-mountain-0
Dec 4, 2025
Merged

Kitenite merged 1 commit into
mainfrom
teal-mountain-0

Conversation

@Kitenite

@Kitenite Kitenite commented Dec 4, 2025

Copy link
Copy Markdown
Member

Summary

  • Close delete workspace dialog immediately when user confirms deletion
  • Run workspace deletion in background with toast notifications for loading/success/error states
  • Remove blocking isDeleting state that previously kept the modal open

Test plan

  • Open a workspace and click the X to delete it
  • Confirm deletion - dialog should close immediately
  • Verify "Deleting..." toast appears while deletion runs
  • Verify success toast appears when deletion completes
  • Test error case by simulating a failure (e.g., permission issue) - error toast should appear

🤖 Generated with Claude Code

@vercel

vercel Bot commented Dec 4, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
website Ready Ready Preview Comment Dec 4, 2025 6:34am

@coderabbitai

coderabbitai Bot commented Dec 4, 2025 •

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@Kitenite has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 49 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between d19976d and d7d99d7.

📒 Files selected for processing (1)
  • apps/desktop/src/renderer/screens/main/components/TopBar/WorkspaceTabs/DeleteWorkspaceDialog.tsx (2 hunks)
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch teal-mountain-0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Close the delete dialog immediately and run deletion in background.
Shows loading/success/error toasts to provide feedback without blocking UI.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@Kitenite
Kitenite merged commit 92a548d into main Dec 4, 2025
7 checks passed
@Kitenite
Kitenite deleted the teal-mountain-0 branch December 4, 2025 06:35

This branch was successfully deployed

1 active deployment
Preview — d7d99d74 Deployed Dec 4, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant