Repository navigation
fix(docs): bump postcss to 8.5.25 to patch source-map path traversal - #6156
Conversation
Dependabot alert #259 (GHSA-fxqj-rqcc-2cmp, CVE-2026-69153): postcss's fix for the earlier sourceMappingURL traversal advisory only guarded the path when `from` is set. Without `from`, an attacker-controlled CSS comment could still read arbitrary .map files off disk. Fixed upstream in 8.5.23; bumped the apps/docs devDependency to the latest 8.5.25. Claude-Session: https://claude.ai/code/session_01GQgoTe37smR8xJDSr6mVYJ
Greptile SummaryThe PR upgrades the docs application's direct PostCSS dependency to 8.5.25 and updates Bun's dependency resolutions to incorporate the patched release.
Confidence Score: 5/5The PR appears safe to merge, with no actionable regressions identified in the dependency bump or lockfile update. The docs manifest and lockfile consistently resolve the direct PostCSS dependency to 8.5.25, and the retained scoped 8.5.18 entries do not execute on the reviewed docs PostCSS processing path.
|
| Filename | Overview |
|---|---|
| apps/docs/package.json | Upgrades the docs app's direct PostCSS development dependency to the patched 8.5.25 release. |
| bun.lock | Resolves the direct PostCSS dependency to 8.5.25 and records the resulting scoped transitive resolutions without exposing a concrete docs-path regression. |
Reviews (1): Last reviewed commit: "fix(docs): bump postcss to 8.5.25 to pat..." | Re-trigger Greptile
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe docs application updates its ChangesPostCSS dependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
There was a problem hiding this comment.
No issues found across 2 files
Architecture diagram
sequenceDiagram
participant Dev as Developer
participant Docs as apps/docs
participant PostCSS as PostCSS (8.5.25)
participant SourceMap as Source Map Parser
participant FileSystem as File System
Note over Dev,FileSystem: PostCSS source-map path traversal fix flow
Dev->>Docs: Run build with postcss
Docs->>PostCSS: Invoke process() with CSS + sourceMappingURL comment
alt PostCSS invoked WITH opts.from set
PostCSS->>SourceMap: Parse sourceMappingURL comment
SourceMap->>SourceMap: CHANGED: Validate source map path (reject absolute/.. traversal)
alt Path is valid
SourceMap->>FileSystem: Read .map file
FileSystem-->>SourceMap: Map content
SourceMap-->>PostCSS: Return parsed source map
PostCSS->>PostCSS: Merge sources/sourcesContent into output
else Path is malicious (e.g., ../../../etc/passwd.map)
SourceMap-->>PostCSS: Return empty/cached fallback
PostCSS-->>Docs: Generate output without leaked source data
end
else PostCSS invoked WITHOUT opts.from
alt PostCSS 8.5.18 (vulnerable)
PostCSS->>SourceMap: Parse sourceMappingURL comment
SourceMap->>SourceMap: Skip path validation (guard not executed)
SourceMap->>FileSystem: Read arbitrary .map file from disk
FileSystem-->>SourceMap: Leaked file contents
SourceMap-->>PostCSS: Return parsed source map with sensitive data
PostCSS-->>Docs: Generate output with leaked sources
else PostCSS 8.5.25 (fixed)
PostCSS->>SourceMap: Parse sourceMappingURL comment
SourceMap->>SourceMap: NEW: Always validate source map path (even without from)
alt Path is malicious
SourceMap-->>PostCSS: Return empty/cached fallback
PostCSS-->>Docs: Generate output without leaked source data
else Path is valid
SourceMap->>FileSystem: Read .map file
FileSystem-->>SourceMap: Map content
SourceMap-->>PostCSS: Return parsed source map
PostCSS-->>Docs: Generate output with valid sources
end
end
end
Summary
postcssdevDependency inapps/docs/package.jsonfrom8.5.18→8.5.25(latest), which includes the8.5.23security patch.Why / Context
Fixes Dependabot alert #259 (GHSA-fxqj-rqcc-2cmp, CVE-2026-69153, medium severity).
The earlier fix for GHSA-6g55-p6wh-862q added a guard in
previous-map.jsthat rejects absolute paths /..traversal in an attacker-controlledsourceMappingURL— but that guard only runs whenopts.fromis set. When PostCSS is invoked withoutfrom, the guard is skipped, so a crafted/*# sourceMappingURL=... */comment could still make PostCSS read an arbitrary.mapfile off disk and leak itssources/sourcesContentinto the generated map. Fixed upstream in8.5.23.Manual QA Checklist
postcssdevDependency inapps/docs/package.json(only open postcss alert on the repo; fix(desktop): make workspace deletion async with toast feedback #253/fix(desktop): only show workspace name in notifications when meaningful #248/cleanup #67 are already marked fixed)bun.lockresolvespostcssforapps/docsto8.5.25Testing
bun install(lockfile updated cleanly)bun run typecheck(apps/docs)bun run lint(root)Known Limitations
postcss@8.5.18/8.4.31copies still exist elsewhere in the tree (via@tailwindcss/postcss,vite,@expo/metro-config,next), but Dependabot isn't currently flagging those as separate alerts, so they're out of scope for this fix.Summary by cubic
Bump
postcssinapps/docsfrom 8.5.18 to 8.5.25 to patch the source-map path traversal vulnerability and resolve Dependabot alert #259 (GHSA-fxqj-rqcc-2cmp / CVE-2026-69153). Lockfile updated.Written for commit 3eaeb06. Summary will update on new commits.
Summary by CodeRabbit