Repository navigation
fix(desktop): restore SUPERSET_ROOT_PATH and related env vars to terminal - #311
Conversation
…inal Re-add environment variables that were accidentally removed in #303: - SUPERSET_WORKSPACE_NAME: The workspace name - SUPERSET_WORKSPACE_PATH: The worktree path - SUPERSET_ROOT_PATH: The main repo path These are needed by setup/teardown scripts that run in terminal sessions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThis PR extends the terminal creation flow to propagate workspace metadata through the system. The terminal router now resolves workspace and project information, passing workspace name, workspace path, and root path as additional parameters to the TerminalManager, which forwards these values into terminal session environment configuration. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used📓 Path-based instructions (5)apps/desktop/**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (apps/desktop/AGENTS.md)
Files:
apps/desktop/**/*.{ts,tsx}📄 CodeRabbit inference engine (apps/desktop/AGENTS.md)
Files:
**/*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
apps/desktop/src/lib/**/*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
apps/desktop/src/main/lib/terminal-*.ts📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧠 Learnings (3)📓 Common learnings📚 Learning: 2025-12-08T23:32:32.232ZApplied to files:
📚 Learning: 2025-12-08T23:32:32.232ZApplied to files:
🧬 Code graph analysis (1)apps/desktop/src/lib/trpc/routers/terminal/terminal.ts (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Closes Dependabot alerts #311, #312, #313, #314 (hono/jsx renders plain strings unescaped in boundary components, XSS). hono resolves through the root override and sherif requires one version across workspaces, so the override and all four workspace manifests move together. Co-authored-by: Claude <noreply@anthropic.com>
Summary
SUPERSET_WORKSPACE_NAME,SUPERSET_WORKSPACE_PATH, andSUPERSET_ROOT_PATHto terminal sessionsTest plan
env | grep SUPERSETand verify all env vars are present🤖 Generated with Claude Code
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.