Repository navigation
Conversation
The daemon-based terminal manager was merging the daemon's process.env with the filtered environment from buildTerminalEnv(). This caused inconsistent behavior between persistent and non-persistent modes: - Non-persistent: uses only the filtered env from buildTerminalEnv() - Persistent: merged daemon's process.env + filtered env The daemon's process.env could be stale (from when daemon was first spawned) or contain different values than expected, leading to unpredictable terminal environments. Now both modes use only the filtered env from buildTerminalEnv(), ensuring consistent and predictable behavior.
📝 WalkthroughWalkthroughSimplified subprocess environment variable handling in terminal session creation by replacing manual filtering and merging logic with direct object spreading, reducing code complexity while maintaining equivalent functionality across the process environment setup. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ions" This reverts commit 6d1c275.
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on February 14. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
…sions" This reverts commit 64e29dd.
Summary
process.envwith the filtered env frombuildTerminalEnv()process.envcould be stale or contain unexpected values, leading to unpredictable terminal environmentsbuildTerminalEnv(), ensuring consistent behaviorTest plan
pkill -f "terminal-host.js"bun devinside a Superset terminal to verify env vars work correctlyNote
Ensures persistent terminal sessions use the same environment as non-persistent mode.
session.tsspawn(), buildprocessEnvsolely from the provided filteredenvand setTERMtoxterm-256colorprocess.env, preventing stale or unexpected variablesWritten by Cursor Bugbot for commit 6d1c275. This will update automatically on new commits. Configure here.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.