Repository navigation
fix(api): drop mcpEndSession from openapi and delete stale MCP_TOOLS.md - #6028
Conversation
The v2 MCP transport is stateless (no sessionIdGenerator), so the advertised DELETE /api/v2/agent/mcp session-termination operation has no session to end. MCP_TOOLS.md was a pre-implementation design doc still describing v1-era tool names and an auth scheme that never shipped. Claude-Session: https://claude.ai/code/session_01Kub4p3Eim9pc1qaRRmGea2
|
Ready to review this PR? Stage has broken it down into 2 individual chapters for you:
Chapters generated by Stage for commit 54739e4 on Jul 28, 2026 10:12pm UTC. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThe MCP tools documentation was deleted, and the OpenAPI specification no longer advertises the DELETE operation for terminating ChangesMCP documentation and API specification
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Part of the MCP v2 rework (Phase 0b).
mcpEndSessionDELETE operation from the hand-authored openapi.json — the v2 MCP transport is stateless (nosessionIdGenerator), so there is no session to terminate and the advertised operation was a lie.apps/api/MCP_TOOLS.md: a 306-line pre-implementation design doc documenting v1-era tool names (create_task,create_worktree), anX-API-Keyauth scheme that never shipped, and 12 tools against the real 31. Nothing references it.No behavior change.
https://claude.ai/code/session_01Kub4p3Eim9pc1qaRRmGea2
Summary by cubic
Removed the
mcpEndSessionDELETE operation from the OpenAPI spec and deleted the outdatedapps/api/MCP_TOOLS.mddesign doc. MCP v2 transport is stateless, so session termination is invalid; no runtime behavior changes.Written for commit 54739e4. Summary will update on new commits.
Summary by CodeRabbit
Documentation
API Changes