Skip to content

fix(api): drop mcpEndSession from openapi and delete stale MCP_TOOLS.md - #6028

Merged
saddlepaddle merged 1 commit into
mainfrom
mcp-rework/0b-openapi-endsession
Jul 31, 2026
Merged

saddlepaddle merged 1 commit into
mainfrom
mcp-rework/0b-openapi-endsession

Conversation

@saddlepaddle

@saddlepaddle saddlepaddle commented Jul 28, 2026 •

Copy link
Copy Markdown
Collaborator

Part of the MCP v2 rework (Phase 0b).

  • Removes the mcpEndSession DELETE operation from the hand-authored openapi.json — the v2 MCP transport is stateless (no sessionIdGenerator), so there is no session to terminate and the advertised operation was a lie.
  • Deletes apps/api/MCP_TOOLS.md: a 306-line pre-implementation design doc documenting v1-era tool names (create_task, create_worktree), an X-API-Key auth scheme that never shipped, and 12 tools against the real 31. Nothing references it.

No behavior change.

https://claude.ai/code/session_01Kub4p3Eim9pc1qaRRmGea2


Open in Stage

Summary by cubic

Removed the mcpEndSession DELETE operation from the OpenAPI spec and deleted the outdated apps/api/MCP_TOOLS.md design doc. MCP v2 transport is stateless, so session termination is invalid; no runtime behavior changes.

Written for commit 54739e4. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Documentation

    • Removed the Superset MCP server tools documentation.
  • API Changes

    • Removed OpenAPI documentation for terminating MCP sessions through the DELETE endpoint.
    • MCP stream access documentation remains available.

The v2 MCP transport is stateless (no sessionIdGenerator), so the
advertised DELETE /api/v2/agent/mcp session-termination operation has no
session to end. MCP_TOOLS.md was a pre-implementation design doc still
describing v1-era tool names and an auth scheme that never shipped.

Claude-Session: https://claude.ai/code/session_01Kub4p3Eim9pc1qaRRmGea2
@ghost

ghost commented Jul 28, 2026

Copy link
Copy Markdown

Ready to review this PR? Stage has broken it down into 2 individual chapters for you:

Title
1 Remove obsolete mcpEndSession from OpenAPI spec
2 Delete stale MCP_TOOLS design documentation
Open in Stage

Chapters generated by Stage for commit 54739e4 on Jul 28, 2026 10:12pm UTC.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6b0abf7a-60f5-4856-bbe0-0b22c915d8e6

📥 Commits

Reviewing files that changed from the base of the PR and between 24eb5c1 and 54739e4.

📒 Files selected for processing (2)
  • apps/api/MCP_TOOLS.md
  • apps/api/src/app/openapi.json/route.ts
💤 Files with no reviewable changes (2)
  • apps/api/src/app/openapi.json/route.ts
  • apps/api/MCP_TOOLS.md

📝 Walkthrough

Walkthrough

The MCP tools documentation was deleted, and the OpenAPI specification no longer advertises the DELETE operation for terminating /api/v2/agent/mcp sessions.

Changes

MCP documentation and API specification

Layer / File(s) Summary
Remove MCP session termination documentation
apps/api/MCP_TOOLS.md, apps/api/src/app/openapi.json/route.ts
The MCP tools documentation was removed, and the OpenAPI DELETE /api/v2/agent/mcp operation, required session header, and responses were deleted.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • superset-sh/superset#5912: Reinstates the MCP session GET/DELETE operations in the OpenAPI specification, directly relating to this removal.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers what changed and why, but it omits the required testing section and checklist items. Add a 'How I tested it' section and complete the checklist, including lint/typecheck status or a clear note that no tests were run.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise, conventional, and accurately summarizes the OpenAPI and MCP_TOOLS.md removal.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mcp-rework/0b-openapi-endsession

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 28, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

@saddlepaddle
saddlepaddle merged commit 1263c82 into main Jul 31, 2026
18 checks passed
@saddlepaddle
saddlepaddle deleted the mcp-rework/0b-openapi-endsession branch July 31, 2026 23:45

This branch was previously deployed

1 inactive deployment
preview — 54739e41 Deployed Jul 28, 2026 by saddlepaddle via Deploy Docs #6911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant