Skip to content

fix(command-center): question prompt no longer blocks thread scroll#3448

Merged
charlesvien merged 1 commit into
PostHog:mainfrom
digvijay208:fix/question-prompt-blocks-scroll-2510
Jul 22, 2026
Merged

fix(command-center): question prompt no longer blocks thread scroll#3448
charlesvien merged 1 commit into
PostHog:mainfrom
digvijay208:fix/question-prompt-blocks-scroll-2510

Conversation

@digvijay208

Copy link
Copy Markdown
Contributor

Summary

Fixes #2510.

When a question/permission prompt appeared in a Command Center cell, the ComposerSlot wrapper had shrink-0, preventing the flex layout from yielding space to the ThreadView above. Combined with ActionSelector's max-h-[80vh] (80% of the viewport, not the cell), the question card could consume the entire visible area in a compact command-center cell, making it impossible to scroll up to read past messages.

Root cause

Flex column (height: 100% of cell)
|-- ThreadView   -> min-h-0 flex-1 (scrollable)  <- got crushed to 0
`-- ComposerSlot -> shrink-0 [x] + ActionSelector max-h-[80vh] [x]

Changes

packages/ui/src/features/sessions/components/SessionView.tsx

In ComposerSlot, drop shrink-0 and add max-h-[50%] in compact mode so the question card never consumes more than half the cell height. The thread above remains scrollable. Non-compact (full task view) behavior is unchanged.

Testing

  • Open the Command Center with a task that triggers a question prompt (multi-step question tool call)
    • Confirm the conversation thread is still visible and scrollable above the question card
    • Confirm the question card itself scrolls if content is taller than 50% of the cell
    • Confirm full task view (non-compact) works exactly as before

@trunk-io

trunk-io Bot commented Jul 14, 2026

Copy link
Copy Markdown

😎 This pull request was merged.

@trunk-io

trunk-io Bot commented Jul 14, 2026

Copy link
Copy Markdown

An error occurred while submitting your PR to the queue: Only users that are a part of this repo's Trunk organization or have write permissions to the repo can submit a PR to the queue

@github-actions

Copy link
Copy Markdown

This PR has had no activity for 7 days and has been marked stale. We are moving to the monorepo and tightening PR staleness in preparation, so it will be closed in 7 days if no further activity occurs.

@github-actions github-actions Bot added the stale No recent changes to PR label Jul 22, 2026
When a question/permission prompt appeared in a Command Center cell,
the ComposerSlot wrapper had shrink-0, preventing the flex parent
from keeping the ThreadView visible. Combined with ActionSelector's
max-h-[80vh] (80% of the viewport, not the cell), the question card
could consume the entire compact cell, making it impossible to scroll
up to see past messages.

Fix: in compact mode, drop shrink-0 and cap the slot at max-h-[50%]
of the parent. The question prompt scrolls internally via
overflow-y-auto if it's taller than half the cell, while the
ThreadView above remains accessible. Non-compact behavior is unchanged.

Fixes PostHog#2510
@charlesvien
charlesvien force-pushed the fix/question-prompt-blocks-scroll-2510 branch from 6648ef4 to 4000d48 Compare July 22, 2026 06:33
@charlesvien charlesvien removed the stale No recent changes to PR label Jul 22, 2026
@charlesvien
charlesvien merged commit ed26e21 into PostHog:main Jul 22, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

question prompt in command center blocks content

2 participants