Repository navigation
feat(integration): make the integration config a variant table with per-product pages - #528
Conversation
…er-product pages Each integration variant lists its error tracking and feature flag pages under `docs`, taken from the two step skills that ship them today, and names the variant it is written for under `match`. The build writes each product's pages to `references/<product>/` in the pack, lists them in a `variant.json` at the pack's root, and publishes `match` as `key:value` menu tags. SKILL.md lists none of the new files, so every pack's SKILL.md is unchanged. The build fails when a row has neither pages nor a declared gap for a product. `check:bundle-diff --additive` passes when a build only adds: files, zip entries, menu entries and fields. Co-Authored-By: Claude <noreply@anthropic.com>
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a wizard branch:
Add Results will be posted here when complete. |
A `match` key is a trait name as the wizard spells it, and the wizard's trait for a framework's variant is `frameworkVariant`. The 14 rows that name a variant use that key, so their packs publish `frameworkVariant:<value>` tags, and the build rejects a key that is not a trait name. Co-Authored-By: Claude <noreply@anthropic.com>
|
my agent caught an existing error-tracking docs issue that carries over into the new packs: some error-tracking guides and general sdk guides have the same filename, so the sdk guide overwrites the error-tracking guide during the build. it confirmed this locally for fastapi ( this happens in the old packages too, so the before/after checks pass even though those guides are missing. these need distinct filenames, with the references updated to match, so both pages make it into the pack. |
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
See inline comments.
Automated review by Glimmervoid. Not written by a human
gewenyu99
left a comment
There was a problem hiding this comment.
🥸 Reviewed by NotVincent, totally not Vincent. The real Vincent will review it separately. Probably slop, please disregard.
…day's Nuxt page Two pages of a skill were written under the last part of their URL, so `error-tracking/installation/python.md` and `libraries/python.md` both became `python.md` and the second replaced the first. The skill listed both titles and shipped one page. When two pages of a folder share that part, each now takes its parent part too: `installation-python.md` and `libraries-python.md`. The build fails when two pages would still be written under one name. One writer handles every page, in `references/` and in a product's folder. This restores a page in the error tracking step for Expo, FastAPI, SvelteKit, Swift and WordPress, in the packs that carry the same pages, and in six other skills: error-tracking-dotnet, error-tracking-ruby-on-rails, feature-flags-dotnet, feature-flags-aspnetcore-feature-management, omnibus-instrument-error-tracking and omnibus-instrument-feature-flags. The default Nuxt row lists the 3.7 error tracking page. A run picks a step skill by framework and takes that family's default, which for error tracking is nuxt-4, so that is the page a Nuxt run reads today. The row test now compares each row with the step variant a run on it reads. Co-Authored-By: Claude <noreply@anthropic.com>
`check-bundle-diff --additive` compared a list that is empty in the baseline as one value, so its first record read as a change. An empty list has nothing to keep, so everything the candidate lists is an addition. The comparison moves to scripts/lib/additive-diff.js, with tests. Co-Authored-By: Claude <noreply@anthropic.com>
…nd match A product listed twice, a product name that is not kebab-case, a match value with a colon and a match that is a list are each rejected, and a test now says so. Co-Authored-By: Claude <noreply@anthropic.com>
gewenyu99
left a comment
There was a problem hiding this comment.
🥸 Reviewed by NotVincent, totally not Vincent. The real Vincent will review it separately. Probably slop, please disregard.
Summary
context/skills/integration/config.yamlbecomes the variant table. Each row names the variant it is written for undermatch, and lists the error tracking and feature flag pages for that variant underdocs. The build writes those pages into the row's pack, lists them in avariant.jsonat the pack's root, and publishes the variant as a menu tag.Every pack's
SKILL.mdis byte-identical, and the table only adds files and tags. One fix changes skills published today: two pages of a skill that share a file name are now both written, where the second replaced the first.Stack
The second half of the migration, behind
wizard-agent-dag-skills. The first half, behindwizard-agent-dag, is in context-mill 1.65.0 (#447) and wizard 2.94.0 (PostHog/wizard#1551 to PostHog/wizard#1554).variant.json.main. Adds files and tags, and writes both pages where one replaced another.integration-<step>.main, on its own. Documentation only. Merges whenwizard-agent-dagreaches 100%.wizard-agent-dag-skillson, a task reads the step skill from B, completed from the pack from A.main. Does nothing while the flag is off.A and B are one GitHub stack and merge together. Apart from the page fix in A, they only add files, skills and tags, and no run reads those until the flag is on.
Rollout
wizard-agent-dag-skillsis a percentage flag, independent ofwizard-agent-dag. Turning it off returns every run to the skills it reads today, and a run pinned to a context-mill release reads those throughout.check:bundle-diff --additiveandcheck:repackaged-skillson the release buildpnpm verify:repackaged-skillsagainst the release, and a workbench run with the flag on compared with one with it off.orchestrator_skillstag: run success, task failures, and anyorchestrator repackaged skill unavailableC merges on its own, when
wizard-agent-dagreaches 100%.What a row gains
matchframeworkVariantis the id the wizard's framework config reports.docsdocs_urlsstays the integration pages.gapsproducts, on the groupA row lists its own pages for a product: the ones under
docs_urlsin the matching variant ofintegration-v2-error-tracking-stepandintegration-v2-feature-flags-step. Pages a step shares across every framework, such as the three feature flag guides, are that step'sshared_docsand ship in the step skill (#529), not in a row.A run picks a step skill by framework and takes that family's default. So a test compares each framework's default row with the step's default variant, and every other row with the variant of its own id.
The default Nuxt row
nuxtnuxt-3-6integration-v2-error-tracking-stepnuxt-4nuxt-3-7.mdA Nuxt run takes the
nuxt-3-6pack and reads the 3.7 error tracking page today. Thenuxt-3-6row lists that page, so a run reads the same page from its pack. A Nuxt 4 project gets the Nuxt 4 pack onceframeworkVariantis a match key in the wizard.Pages that share a file name
A page was written under the last part of its URL, so
error-tracking/installation/python.mdandlibraries/python.mdboth becamepython.md. The skill listed both titles, and the second page replaced the first.installation-python.mdandlibraries-python.mdnext-js.mdOne writer handles every page, in
references/and in a product's folder. The fix restores a page in:integration-v2-error-tracking-step, for Expo, FastAPI, SvelteKit, Swift and WordPress, and the packs that carry the same pages.error-tracking-dotnetanderror-tracking-ruby-on-rails.feature-flags-dotnetandfeature-flags-aspnetcore-feature-management.omnibus-instrument-error-trackingandomnibus-instrument-feature-flags.posthog-all,posthog-error-trackingandposthog-feature-flags.What a pack gains
references/<product>/variant.jsonat the pack's rootframeworkVariant:<value>tagframeworkVariantis a match keyA product's pages have a folder of their own because two products can have a page of the same name: the React library page and the React error tracking page are both
react.md.SKILL.mdlists none of the new files, so it reads as it does today. Every reader of a pack gets the new files with it: 5 to 8 more files a pack, 39 KB unpacked at the median.Variant values
Fourteen rows name a
frameworkVariant. The values are the ids the wizard's framework configs report, and the wizard's trait takes the same name in PostHog/wizard#1559.frameworkVariantnextjsapp-router,pages-routerreact-routerv6,v7-framework,v7-data,v7-declarativetanstack-routerfile-based,code-basedastrostatic,ssr,hybrid,view-transitionsreact-nativeexpo. Thereact-nativerow names nonenuxt4.xonnuxt-4. Thenuxt-3-6row names noneA row with no
frameworkVariantserves every value its framework's other rows do not name. The wizard supplies onlyframeworkas a match key today, so the new tags change no pick.What does not change
SKILL.mdin all 40 packs, byte for byte.skills-mcp-resources.zipis 13.2 MB against a 16 MB limit.check:bundle-diffgains--additive, for a release that only adds. It allows a file, a zip entry, a menu entry or a field the baseline lacks, and fails on anything the baseline has that is changed or gone. A list that is empty in the baseline has nothing to keep, so its first records count as additions.Kept as it is
react-vite,javascript_nodeandjavascript_webname their example underexample_path, a key the build does not read, so they ship withoutEXAMPLE.md. Reading it would change theirSKILL.md.Test plan
pnpm test: 390 tests pass, 40 of them newpnpm build, thenpnpm check:bundle-diff --additiveagainst a build ofmain: 54 differences, every one in the eleven skills with the page fix and their marketplace copiesvariant-table.test.js: the build writes the pages andvariant.json, leavesSKILL.mdand every other file as they were, rejects a row with neither pages nor a gap, gives two pages that share a file name their parent part, rejects two that would still share one, rejects a product listed twice and a match value with a colon, and each row's pages equal the pages of the step variant a run on it readsadditive-diff.test.js: what counts as kept, changed, removed and added🤖 Generated with Claude Code