Repository navigation
refactor(traits): name the variant trait frameworkVariant - #1560
Closed
edwinyjlim wants to merge 1 commit into
Closed
edwinyjlim wants to merge 1 commit into
edwinyjlim wants to merge 1 commit into
Conversation
The trait that holds a framework's variant is `frameworkVariant`. It reads the same value: the stable id a framework config returns from `getVariant`, such as `pages-router` or `expo`. Nothing reads the trait yet and it is not a match key, so no run changes. Co-Authored-By: Claude <noreply@anthropic.com>
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folded into #1559, which carries this same commit.
Summary
The trait that holds a framework's variant is
frameworkVariant. It reads the same value: the stable id a framework config returns fromgetVariant, such aspages-routerorexpo.Nothing reads the trait yet and it is not a match key, so no run changes.
How it lines up with context-mill
A skill matches a trait through a
<trait>:<value>tag, so a trait's name is the tag key context-mill publishes. PostHog/context-mill#528 publishesframeworkVariant:<value>on each pack written for one variant, such asframeworkVariant:pages-router.Traitsin the program contract, and the trait registryframeworkVariantmatchin context-millframeworkVariant: pages-routerframeworkVariant:pages-routergetVariant, unchangedTest plan
pnpm typecheckpnpm lintpnpm exec vitest run src/services/project-traits: 40 tests pass🤖 Generated with Claude Code