Skip to content

recording: OnTouchEventListener try catch guard to swallow unexpected errors - #147

Merged
marandaneto merged 2 commits into
mainfrom
fix/OnTouchEventListener-crash
Jun 27, 2024
Merged

marandaneto merged 2 commits into
mainfrom
fix/OnTouchEventListener-crash

Conversation

@marandaneto

@marandaneto marandaneto commented Jun 27, 2024 •

Copy link
Copy Markdown
Member

💡 Motivation and Context

Events from https://play.google.com/sdk-console v3.3.1

1

Exception java.lang.IllegalStateException: Fragment already added
at androidx.fragment.app.Fragment.setInitialSavedState (Fragment.java:833)
at
at android.view.View.layout (View.java:24475)
at android.view.ViewGroup.layout (ViewGroup.java:7383)
at
at android.view.View.layout (View.java:24475)
at android.view.ViewGroup.layout (ViewGroup.java:7383)
at
at android.view.View.layout (View.java:24475)
at android.view.ViewGroup.layout (ViewGroup.java:7383)
at
at android.view.View.layout (View.java:24475)
at android.view.ViewGroup.layout (ViewGroup.java:7383)
at android.widget.FrameLayout.layoutChildren (FrameLayout.java:332)
at android.widget.FrameLayout.onLayout (FrameLayout.java:270)
at android.view.View.layout (View.java:24475)
at android.view.ViewGroup.layout (ViewGroup.java:7383)
at
at android.view.View.dispatchTouchEvent (View.java:15199)
at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3914)
at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:3578)
at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3920)
at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:3594)
at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3920)
at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:3594)
at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3920)
at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:3594)
at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3920)
at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:3594)
at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3920)
at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:3594)
at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3920)
at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:3594)
at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3920)
at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:3594)
at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3920)
at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:3594)
at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3920)
at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:3594)
at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3920)
at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:3594)
at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3920)
at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:3594)
at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3920)
at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:3594)
at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3920)
at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:3594)
at android.view.ViewGroup.dispatchTransformedTouchEvent (ViewGroup.java:3920)
at android.view.ViewGroup.dispatchTouchEvent (ViewGroup.java:3594)
at com.android.internal.policy.DecorView.superDispatchTouchEvent (DecorView.java:913)
at com.android.internal.policy.PhoneWindow.superDispatchTouchEvent (PhoneWindow.java:1957)
at android.app.Activity.dispatchTouchEvent (Activity.java:4182)
at
at curtains.internal.WindowCallbackWrapper$dispatchTouchEvent$dispatch$1.invoke (WindowCallbackWrapper.kt:58)
at curtains.internal.WindowCallbackWrapper$dispatchTouchEvent$dispatch$1.invoke (WindowCallbackWrapper.kt:52)
at curtains.OnTouchEventListener$DefaultImpls.intercept (OnTouchEventListener.java:96)
at com.posthog.android.replay.PostHogReplayIntegration$onTouchEventListener$1.intercept (PostHogReplayIntegration.kt:195)
at curtains.internal.WindowCallbackWrapper.dispatchTouchEvent (WindowCallbackWrapper.kt:65)
at com.android.internal.policy.DecorView.dispatchTouchEvent (DecorView.java:871)
at android.view.View.dispatchPointerEvent (View.java:15458)
at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent (ViewRootImpl.java:7457)
at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess (ViewRootImpl.java:7233)
at android.view.ViewRootImpl$InputStage.deliver (ViewRootImpl.java:6595)
at android.view.ViewRootImpl$InputStage.onDeliverToNext (ViewRootImpl.java:6652)
at android.view.ViewRootImpl$InputStage.forward (ViewRootImpl.java:6618)
at android.view.ViewRootImpl$AsyncInputStage.forward (ViewRootImpl.java:6786)
at android.view.ViewRootImpl$InputStage.apply (ViewRootImpl.java:6626)
at android.view.ViewRootImpl$AsyncInputStage.apply (ViewRootImpl.java:6843)
at android.view.ViewRootImpl$InputStage.deliver (ViewRootImpl.java:6599)
at android.view.ViewRootImpl$InputStage.onDeliverToNext (ViewRootImpl.java:6652)
at android.view.ViewRootImpl$InputStage.forward (ViewRootImpl.java:6618)
at android.view.ViewRootImpl$InputStage.apply (ViewRootImpl.java:6626)
at android.view.ViewRootImpl$InputStage.deliver (ViewRootImpl.java:6599)
at android.view.ViewRootImpl.deliverInputEvent (ViewRootImpl.java:9880)
at android.view.ViewRootImpl.doProcessInputEvents (ViewRootImpl.java:9718)
at android.view.ViewRootImpl.enqueueInputEvent (ViewRootImpl.java:9671)
at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent (ViewRootImpl.java:10014)
at android.view.InputEventReceiver.dispatchInputEvent (InputEventReceiver.java:220)
at android.view.InputEventReceiver.nativeConsumeBatchedInputEvents
at android.view.InputEventReceiver.consumeBatchedInputEvents (InputEventReceiver.java:200)
at android.view.ViewRootImpl.doConsumeBatchedInput (ViewRootImpl.java:9960)
at android.view.ViewRootImpl$ConsumeBatchedInputRunnable.run (ViewRootImpl.java:10056)
at android.view.Choreographer$CallbackRecord.run (Choreographer.java:1010)
at android.view.Choreographer.doCallbacks (Choreographer.java:809)
at android.view.Choreographer.doFrame (Choreographer.java:737)
at android.view.Choreographer$FrameDisplayEventReceiver.run (Choreographer.java:995)
at android.os.Handler.handleCallback (Handler.java:938)
at android.os.Handler.dispatchMessage (Handler.java:99)
at android.os.Looper.loop (Looper.java:246)
at android.app.ActivityThread.main (ActivityThread.java:8625)
at java.lang.reflect.Method.invoke
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:602)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1130)

2

"main" tid=1 Native
#00 pc 0x000000000009eeb8 /apex/com.android.runtime/lib64/bionic/libc.so (fsync+8)
#1 pc 0x0000000000004700 /apex/com.android.art/lib64/libopenjdkjvm.so (JVM_Sync+20)
#2 pc 0x0000000000022404 /apex/com.android.art/lib64/libopenjdk.so (FileDescriptor_sync+40)
#3 pc 0x0000000000351e30 /apex/com.android.art/lib64/libart.so (art_quick_generic_jni_trampoline+144)
#4 pc 0x00000000005b9930 /apex/com.android.art/lib64/libart.so (nterp_helper+4016)
#5 pc 0x000000000043c654 /system/framework/framework.jar (android.os.FileUtils.sync+12)
at
#7 pc 0x00000000005ba754 /apex/com.android.art/lib64/libart.so (nterp_helper+7636)
at
#9 pc 0x00000000005b98d4 /apex/com.android.art/lib64/libart.so (nterp_helper+3924)
at
#11 pc 0x00000000005b98d4 /apex/com.android.art/lib64/libart.so (nterp_helper+3924)
at
#13 pc 0x00000000005badcc /apex/com.android.art/lib64/libart.so (nterp_helper+9292)
at
#15 pc 0x00000000005badcc /apex/com.android.art/lib64/libart.so (nterp_helper+9292)
at
#17 pc 0x00000000005b98d4 /apex/com.android.art/lib64/libart.so (nterp_helper+3924)
at
#19 pc 0x00000000005ba6f4 /apex/com.android.art/lib64/libart.so (nterp_helper+7540)
at
#21 pc 0x00000000005b89b4 /apex/com.android.art/lib64/libart.so (nterp_helper+52)
at
#23 pc 0x00000000005ba6f4 /apex/com.android.art/lib64/libart.so (nterp_helper+7540)
at
#25 pc 0x00000000005badcc /apex/com.android.art/lib64/libart.so (nterp_helper+9292)
at
#27 pc 0x000000000033b3a4 /apex/com.android.art/lib64/libart.so (art_quick_invoke_stub+612)
#28 pc 0x0000000000339404 /apex/com.android.art/lib64/libart.so (art::JValue art::InvokeVirtualOrInterfaceWithVarArgsart::ArtMethod*+772)
#29 pc 0x0000000000560eb8 /apex/com.android.art/lib64/libart.so (art::JNI::CallVoidMethodV+192)
#30 pc 0x00000000000af5e8 /system/lib64/libandroid_runtime.so (_JNIEnv::CallVoidMethod+120)
#31 pc 0x0000000000119e2c /system/lib64/libandroid_runtime.so (android::NativeInputEventReceiver::consumeEvents+364)
#32 pc 0x0000000000119bec /system/lib64/libandroid_runtime.so (android::NativeInputEventReceiver::handleEvent+180)
#33 pc 0x0000000000016bb0 /system/lib64/libutils.so (android::Looper::pollInner+912)
#34 pc 0x00000000000167b8 /system/lib64/libutils.so (android::Looper::pollOnce+112)
#35 pc 0x000000000014e3ec /system/lib64/libandroid_runtime.so (android::android_os_MessageQueue_nativePollOnce+44)
#36 pc 0x0000000000351e30 /apex/com.android.art/lib64/libart.so (art_quick_generic_jni_trampoline+144)
at
#38 pc 0x000000000033b680 /apex/com.android.art/lib64/libart.so (art_quick_invoke_static_stub+640)
#39 pc 0x000000000037cb18 /apex/com.android.art/lib64/libart.so (_jobject* art::InvokeMethod<8>+1556)
#40 pc 0x000000000037c4f4 /apex/com.android.art/lib64/libart.so (art::Method_invoke +32)
#41 pc 0x0000000000351e30 /apex/com.android.art/lib64/libart.so (art_quick_generic_jni_trampoline+144)
at
#43 pc 0x00000000005ba754 /apex/com.android.art/lib64/libart.so (nterp_helper+7636)
#44 pc 0x0000000000268480 /system/framework/framework.jar (com.android.internal.os.ZygoteInit.main+632)
#45 pc 0x000000000033b680 /apex/com.android.art/lib64/libart.so (art_quick_invoke_static_stub+640)
#46 pc 0x00000000004e2a90 /apex/com.android.art/lib64/libart.so (art::JValue art::InvokeWithVarArgs<_jmethodID*>+728)
#47 pc 0x000000000057ab18 /apex/com.android.art/lib64/libart.so (art::JNI::CallStaticVoidMethodV+156)
#48 pc 0x00000000000b0b28 /system/lib64/libandroid_runtime.so (_JNIEnv::CallStaticVoidMethod+120)
#49 pc 0x00000000000bc22c /system/lib64/libandroid_runtime.so (android::AndroidRuntime::start+948)
#50 pc 0x0000000000002580 /system/bin/app_process64 (main+1320)
#51 pc 0x00000000000489e0 /apex/com.android.runtime/lib64/bionic/libc.so (__libc_init+96)
at java.io.FileDescriptor.sync (Native method)
at android.os.FileUtils.sync (FileUtils.java:256)
at android.app.SharedPreferencesImpl.writeToFile (SharedPreferencesImpl.java:807)
at android.app.SharedPreferencesImpl.access$900 (SharedPreferencesImpl.java:59)
at android.app.SharedPreferencesImpl$2.run (SharedPreferencesImpl.java:672)
at android.app.SharedPreferencesImpl.enqueueDiskWrite (SharedPreferencesImpl.java:691)
at android.app.SharedPreferencesImpl.access$100 (SharedPreferencesImpl.java:59)
at android.app.SharedPreferencesImpl$EditorImpl.commit (SharedPreferencesImpl.java:604)
at
at android.app.Activity.dispatchTouchEvent (Activity.java:4241)
at
at curtains.internal.WindowCallbackWrapper$dispatchTouchEvent$dispatch$1.invoke (WindowCallbackWrapper.kt:1)
at curtains.internal.WindowCallbackWrapper$dispatchTouchEvent$dispatch$1.invoke (WindowCallbackWrapper.kt:1)
at curtains.OnTouchEventListener$DefaultImpls.intercept (Listeners.kt:1)
at com.posthog.android.replay.PostHogReplayIntegration$onTouchEventListener$1.intercept (PostHogReplayIntegration.kt:1)
at curtains.internal.WindowCallbackWrapper.dispatchTouchEvent (WindowCallbackWrapper.kt:1)
at com.microsoft.clarity.g.g$b.dispatchTouchEvent (SourceFile:1)
at com.android.internal.policy.DecorView.dispatchTouchEvent (DecorView.java:475)
at android.view.View.dispatchPointerEvent (View.java:14853)
at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent (ViewRootImpl.java:6785)
at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess (ViewRootImpl.java:6567)
at android.view.ViewRootImpl$InputStage.deliver (ViewRootImpl.java:6041)
at android.view.ViewRootImpl$InputStage.onDeliverToNext (ViewRootImpl.java:6098)
at android.view.ViewRootImpl$InputStage.forward (ViewRootImpl.java:6064)
at android.view.ViewRootImpl$AsyncInputStage.forward (ViewRootImpl.java:6229)
at android.view.ViewRootImpl$InputStage.apply (ViewRootImpl.java:6072)
at android.view.ViewRootImpl$AsyncInputStage.apply (ViewRootImpl.java:6286)
at android.view.ViewRootImpl$InputStage.deliver (ViewRootImpl.java:6045)
at android.view.ViewRootImpl$InputStage.onDeliverToNext (ViewRootImpl.java:6098)
at android.view.ViewRootImpl$InputStage.forward (ViewRootImpl.java:6064)
at android.view.ViewRootImpl$InputStage.apply (ViewRootImpl.java:6072)
at android.view.ViewRootImpl$InputStage.deliver (ViewRootImpl.java:6045)
at android.view.ViewRootImpl.deliverInputEvent (ViewRootImpl.java:9124)
at android.view.ViewRootImpl.doProcessInputEvents (ViewRootImpl.java:9064)
at android.view.ViewRootImpl.enqueueInputEvent (ViewRootImpl.java:9019)
at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent (ViewRootImpl.java:9256)
at android.view.InputEventReceiver.dispatchInputEvent (InputEventReceiver.java:259)
at android.os.MessageQueue.nativePollOnce (Native method)
at android.os.MessageQueue.next (MessageQueue.java:335)
at android.os.Looper.loopOnce (Looper.java:195)
at android.os.Looper.loop (Looper.java:342)
at android.app.ActivityThread.main (ActivityThread.java:8143)
at java.lang.reflect.Method.invoke (Native method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:583)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1045)

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

when (motionEvent.action.and(MotionEvent.ACTION_MASK)) {
MotionEvent.ACTION_DOWN -> {
generateMouseInteractions(timestamp, motionEvent, RRMouseInteraction.TouchStart)
try {

@marandaneto marandaneto Jun 27, 2024 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how this could throw but I recall a lot of strange dispatchTouchEvent errors in the past so let's just be super careful.
Better to lose the touch than crashing.

@marandaneto
marandaneto requested a review from a team June 27, 2024 10:03
@marandaneto
marandaneto marked this pull request as ready for review June 27, 2024 10:03

@pauldambra pauldambra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants