Repository navigation
refactor(skills): replace curl/unzip subprocesses with fetch + fflate - #809
Merged
Merged
Conversation
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
Base automatically changed from
posthog-code/skill-install-windows-fallback
to
main
July 6, 2026 21:39
Skill install no longer depends on platform binaries at all: download via built-in fetch (30s abort), extract in-process with fflate. Entries are checked against the destination root (zip-slip) — the containment the shell tools provided for free. No temp file anymore, so skillTmpPath and the extraction fallback chain from the previous commits are gone; downloadSkill becomes async (callers updated). Generated-By: PostHog Code Task-Id: bcb96bcb-e37f-421d-841d-738647c73b8e
gewenyu99
force-pushed
the
posthog-code/skill-install-fflate
branch
from
July 7, 2026 13:40
bcb8c6a to
55b29d0
Compare
gewenyu99
marked this pull request as ready for review
July 7, 2026 13:40
gewenyu99
enabled auto-merge (squash)
July 7, 2026 13:41
sarahxsanders
approved these changes
Jul 7, 2026
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #808.
Skill installs used curl and unzip from the shell. Some machines don't have them, so installs failed. Now we use Node's built-in fetch and the fflate library. No shell tools needed.
Changes: