Repository navigation
fix(skills): retry skill downloads with backoff - #814
Merged
Merged
Conversation
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
edwinyjlim
marked this pull request as ready for review
July 7, 2026 15:59
Skill downloads were a single fetch with a 30s timeout and no retries, so one stalled or flaky connection failed the whole install. - Retry the download up to 3 times with exponential backoff. - Raise the per-attempt timeout from 30s to 60s. - Include every attempt's error in the failure message.
gewenyu99
force-pushed
the
posthog-code/skill-download-retry-fallback
branch
from
July 7, 2026 16:11
ade0e29 to
f3e510a
Compare
Collaborator
Verified: retry recovers transient skill-download failuresUnit + e2e — 30 pass (
Live wizard run — mock skills server injecting failures (targeted at the skill → wizard: |
gewenyu99
approved these changes
Jul 7, 2026
gewenyu99
added a commit
that referenced
this pull request
Sep 1, 2026
Follow-up to #814. The retry loop treated every non-ok response as transient, so a 404 (missing skill) or 403 (bad token) burned the full backoff before failing. Only 5xx, 408, and 429 are worth retrying — the rest propagate immediately via NonRetryableDownloadError. Also allow overriding LOCAL_SKILLS_BASE_URL via WIZARD_LOCAL_SKILLS_BASE_URL so a local context-mill dev server on a non-default port can be pointed at. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill downloads are a single fetch with a 30s timeout and no retries. One stalled or flaky connection fails the whole install.
This PR was rebased onto main after #809 replaced curl with fetch. The curl fallback it originally added is gone; the retry logic now wraps the fetch download.
Changes:
Refs #808.