Skip to content

Update old packages #496

Closed
Closed
Update old packages#496
Labels
PROSE

Description

@bjones1
bjones1
opened on Jul 26, 2023

Running poetry update followed by poetry show --outdated produces the following.

pdfcropmargins 1.0.9   2.0.3  A command-line program to crop the margins of PDF files, with many options.
pydantic       1.10.12 2.1.1  Data validation and settings management using python type hints
pyee           9.0.4   11.0.0 A port of node.js's EventEmitter to python.
pypdf2         2.5.0   3.0.1  A pure-python PDF library capable of splitting, merging, cropping, and transforming PDF files
watchdog       2.3.1   3.0.0  Filesystem events monitoring

From our pyproject.toml, we have:

pdfCropMargins = "~1.0.9"
PyPDF2 = "~2.5"
watchdog = "^2"

Can we update all these to the latest versions? Note that:

  • pydantic-xml requireds pydantic 1.0.
  • pyee is a version-locked playwright dependency.

Activity

  1. bjones1
    added
    PROSE
    on Jul 26, 2023

  2. oscarlevin commented on Jul 27, 2023

    @oscarlevin
    oscarlevin
    on Jul 27, 2023
    Member

    We likely can and should upgrade these. Note that the pypdf2 and pdfcropmargins were set that way because there was an incompatibility race between them, so it took some testing to find a combination that worked. Hopefully in the new versions this is gone.

  3. bjones1 commented on Jul 27, 2023

    @bjones1
    bjones1
    on Jul 27, 2023
    CollaboratorAuthor

    Thanks! What tests can I run to check that these are behaving properly?

  4. bjones1 commented on Jul 27, 2023

    @bjones1
    bjones1
    on Jul 27, 2023
    CollaboratorAuthor

    Per the docs, pdfCropMargins no longer uses PyPDF2. So, I'm removing the PyPDF2 dependency and updating the pdfCropMargins version. It looks like this is used for LaTeX image generation, so I'll run the tests which (I think) check this.

  5. bjones1
    added a commit that references this issue on Jul 27, 2023

    Fix: Update major versions of older packages.

    6ac03d3

  6. oscarlevin commented on Jul 27, 2023

    @oscarlevin
    oscarlevin
    on Jul 27, 2023
    Member

    That's great. I just checked the support thread and found the issue, which showed up when latex-images were generated. So if those work correctly, we should be all set.

  7. oscarlevin
    added a commit that references this issue on Jul 27, 2023

    Fix: Update major versions of older packages. (#499)

    8a159f6

  8. oscarlevin commented on Jul 27, 2023

    @oscarlevin
    oscarlevin
    on Jul 27, 2023
    Member

    Closed by #499

  9. oscarlevin
    closed this as completedon Jul 27, 2023
  10. oscarlevin
    added 3 commits that reference this issue on Aug 1, 2023

    Main merge (#512)

    655b8c3

    Merge latest changes from main (#519)

    0c000d0

    Refactor2 (#544)

    20f4b74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    PROSE

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions