Repository navigation
Refactor2 - #544
Merged
Merged
Refactor2#544
Conversation
Add in new output_dir/output_file structure.
Fix: Correct output-dir/output-filename tests, add more.
* fix zip_templates so it doesn't recreated duplicate devcont (#497) * Fix: Run tests only on a PR; do this on any branch. (#495) * Fix: Run tests only on a PR; do this on any branch. * Fix: Per discussion, also run testing on any pushes to the main branch. * Fix: Update major versions of older packages. (#499) * Fix: Update major versions of older packages. See #496. * Update: poetry.lock based on project file changes. * Fix: Make mapping file platform-independent. (#504) * bubble up warning if a user isn't compatible with upcoming v2 (#505) * bubble up warning if a user isn't compatible with upcoming v2 * add success messages, error report to support --------- Co-authored-by: Oscar Levin <oscar.levin@unco.edu> * bump version to next patch level for nightly releases * revert to previous pdfCropMargins version (#509) * revert to previous pdfCropMargins version * update action to trigger docker * bump version to next patch level for nightly releases * Update deploy-stable.yml Quick fix to get docker to update --------- Co-authored-by: Oscar Levin <oscar.levin@unco.edu> Co-authored-by: Steven Clontz <steven.clontz@gmail.com> Co-authored-by: GitHub Actions Bot <>
* clean up pretext build * reenable codechat * add zip option to html build * incorporate suggestions * add remaining build targets, except custom * add custom build format * fix ensure_webwork_reps
* get generate working * a few minor improvements * Complete merge * remove old build code * add check for finding assets to be built * refactor asset hash function * generate almost working * complete refactor of generate * fix interactive/preview dir bug * fix flake error
Co-authored-by: Oscar Levin <oscar.levin@unco.edu> Just removed some conflicting changes that were no longer needed after generate refactor.
* Add: The Runestone target. * Fix: The WeBWorK target also supports compression.
* fix zip_templates so it doesn't recreated duplicate devcont (#497) * Fix: Run tests only on a PR; do this on any branch. (#495) * Fix: Run tests only on a PR; do this on any branch. * Fix: Per discussion, also run testing on any pushes to the main branch. * Fix: Update major versions of older packages. (#499) * Fix: Update major versions of older packages. See #496. * Update: poetry.lock based on project file changes. * Fix: Make mapping file platform-independent. (#504) * bubble up warning if a user isn't compatible with upcoming v2 (#505) * bubble up warning if a user isn't compatible with upcoming v2 * add success messages, error report to support --------- Co-authored-by: Oscar Levin <oscar.levin@unco.edu> * bump version to next patch level for nightly releases * revert to previous pdfCropMargins version (#509) * revert to previous pdfCropMargins version * update action to trigger docker * bump version to next patch level for nightly releases * Update deploy-stable.yml Quick fix to get docker to update * reconfigure playwright install process (#518) * bump version to next patch level for nightly releases --------- Co-authored-by: Bryan A. Jones <bjones@ece.msstate.edu> Co-authored-by: Steven Clontz <steven.clontz@gmail.com> Co-authored-by: GitHub Actions Bot <>
* update view commands before actual view call * port oldinit's view command * fix typos * start adding persistent server logic * implement reusable server * fix flake errors * remove unneded module * improve keyboard interrupt * improve checking for running server; reporting of url
* wire up deploy with refactor * clean up
* Improvements to view server checking * remove obsolete view functions
Fix issue with xmlid persisting through generate
* Add: Runestone elements for the demo template. * Add: Runestone elements for the article template. * Remove: Runestone elements from the article template. See #526 (comment). * Add: Runestone elements for the book template. * Fix: Update language based on Rob's feedback. * Fix: Update demo template as well. * Fix: Correct indent, avoid hyphens.
* Fix: Black/Flake8/mypy errors (except for oldinit.py). * Fix: Delete, following fac5e44. * Fix: Move default values from Target.server to Project.server; fix syntax. * Fix: Ignore project/oldinit.py in mypy. * Fix: Update to newer mypy. * Fix: Avoid syntax that requires Python 3.9.
Fix generation bug
Get more tests working
* Add: Missing target from default template. * Fix: Correct tests for subset.
* clean up old code * update dependencies * clean up old code * update dependencies * remove depricated test * fix custom_webwork_server test
…540) * Fix: Correct handling of output-filename to prepend the output-dir. * Fix: Flake8.
* fix elaborate build test * add playwright install for previews * Fix view tests with connection errors * flake8
Final-updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should complete the refactor, allowing for a 2.0 release. Big thanks to @bjones1 and @StevenClontz