Repository navigation
fix: backport upstream playground, vanilla, Angular and FAQ changes (batch 2) - #71
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
This PR backports playground safety fixes, vanilla app reorganization, Angular worker handling, and FAQ updates from upstream. The playground now shares a parseArgs helper that safely returns [] for invalid JSON or non-string arrays, preventing crashes in both preview and Run. The vanilla example moves download-assets.js into its own directory and switches to pnpm commands. The Angular example switches to the single-thread core and uses classWorkerURL with a copied worker file since the dev server lacks COOP/COEP headers. The FAQ adds entries on performance, RTSP, input limits, WORKERFS, log types, raw frame differences, and WebM alpha.
review-bot, model nvidia/nemotron-3-ultra-550b-a55b:free, verdict approve
Backports from upstream #977 and #980, adapted to this fork.
parseArgsreturns[]for them, used both for the preview and for Run (the preview calleddata.joinon any parsed value, and Run calledexec(JSON.parse(args))directly).download-assets.jsmoves intoapps/vanilla-appso the example no longer reaches outside its directory. Unlike upstream it keeps core-mt, since the mt pages still use it.release.ymlnow checks the script at its new path. The scripts use pnpm in the README.worker.js404ed.angular.jsoncopies@project516/ffmpeg-wasm/dist/esm/*.jsto/ffmpegandload()getsclassWorkerURL. The example now uses the single-thread core (the dev server sends no COOP/COEP headers) and drops the no-opworkerURL.Not run locally (Raspberry Pi, no Docker or example installs): the Angular build, the vanilla download script, the website build or type check, and upstream's e2e additions (tests/ is out of scope for this PR). The
-sws_flags accurate_rnd+bitexactadvice and the WORKERFS snippet are carried over from upstream behavior and not tested against this fork's cores.