Fixed bugs in ParmEst cov_est function and Estimator class#3980
Open
slilonfe5 wants to merge 6 commits into
Open
Fixed bugs in ParmEst cov_est function and Estimator class#3980slilonfe5 wants to merge 6 commits into
slilonfe5 wants to merge 6 commits into
Conversation
13 tasks
Member
Author
|
@blnicho @mrmundt @jsiirola @adowling2 This PR fixes two bugs to ensure that the number of data points and parameters are only evaluated for the SSE-with-no-supplied-measurement-error case. Two tests are failing on installation, while one is failing on solvers. Kindly review. Very short PR. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
This PR fixes bugs in the Estimator class,
cov_est, and_cov_at_thetafunctions of ParmEstSummary/Motivation:
_cov_at_thetaand not incov_est, as this is only needed when measurement error is not supplied by the userChanges proposed in this PR:
_cov_at_thetaAI-Use Disclosure
or
AI tools contributed to the development of this PR
Review process (select ONE):
Notes for reviewers (optional):
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: