Skip to content

[WIP] ParmEst bug fix: SSE_weighted should support heterogenous measurement errors#3981

Closed
adowling2 wants to merge 2 commits into
Pyomo:mainfrom
adowling2:parmest-multioutput-bug
Closed

[WIP] ParmEst bug fix: SSE_weighted should support heterogenous measurement errors#3981
adowling2 wants to merge 2 commits into
Pyomo:mainfrom
adowling2:parmest-multioutput-bug

Conversation

@adowling2

@adowling2 adowling2 commented Jun 22, 2026

Copy link
Copy Markdown
Member

Fixes # .

Summary/Motivation:

Small ParmEst bug (incorrectly) raises an AssertionError that measurements need to have the same length, which is not the case for SSE_weighted

Changes proposed in this PR:

  • Allows heterogeneous measurement errors
  • Adds a lightweight test to confirm that the AssertionError (or any other errors) are not raised

AI-Use Disclosure

  • AI tools were NOT used during the preparation of this PR

or

  • AI tools contributed to the development of this PR

    • AI tools generated documentation (including the PR description/comments, code comments, and/or Sphinx documentation)
    • AI tools generated tests (baselines, examples, and/or code)
    • AI tools generated code (apart from tests)

    Review process (select ONE):

    • Rewritten: All AI-generated content was rewritten by me before being committed.
    • Reviewed/verified: I retained AI-generated content and verified it before committing. Verification included (as applicable):
      • Ran the code and fixed issues
      • Added and ran tests
      • Checked correctness/logic of code and tests
      • Checked for alignment with the contribution guide
      • Considered security implications
    • As-is: AI-generated content was commited directly to the repository

Before removing the [WIP] / draft tag, I need to switch to "Reviewed/verified". As part of this, I want to discuss with @sscini and @slilonfe5 the names for the functions touched in this code.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@adowling2 adowling2 marked this pull request as draft June 22, 2026 16:03
@adowling2

Copy link
Copy Markdown
Member Author

Closing in favor of #3980

@adowling2 adowling2 closed this Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant