Skip to content

fix(qwikloader): preserve synchronous event modifiers and async event order - #8540

Merged
wmertens merged 1 commit into
build/v2from
v2-qwikloader-event-handling
Apr 10, 2026
Merged

wmertens merged 1 commit into
build/v2from
v2-qwikloader-event-handling

Conversation

@Varixo

@Varixo Varixo commented Apr 8, 2026

Copy link
Copy Markdown
Member
  • prevent default and stop propagation should be called in sync way
  • event handlers should be executed in event calling order

@Varixo Varixo self-assigned this Apr 8, 2026
@Varixo Varixo added the V2 label Apr 8, 2026
@changeset-bot

changeset-bot Bot commented Apr 8, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7ae409d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maiieul maiieul moved this from Backlog to In progress in Qwik Development Apr 8, 2026
@Varixo Varixo changed the title fix(qwikloader): preserve synchronous event modifiers and async event… fix(qwikloader): preserve synchronous event modifiers and async event order Apr 8, 2026
@Varixo
Varixo force-pushed the v2-qwikloader-event-handling branch from 6b0d01b to 2d5e344 Compare April 8, 2026 16:31
@pkg-pr-new

pkg-pr-new Bot commented Apr 8, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@qwik.dev/core

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8540

@qwik.dev/router

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8540

eslint-plugin-qwik

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8540

create-qwik

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8540

@qwik.dev/optimizer

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/optimizer@8540

commit: e0a2ca9

@github-actions

github-actions Bot commented Apr 8, 2026 •

Copy link
Copy Markdown
Contributor
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 2d5e344

@Varixo
Varixo force-pushed the v2-qwikloader-event-handling branch from 2d5e344 to e0a2ca9 Compare April 8, 2026 17:29
@Varixo
Varixo marked this pull request as ready for review April 8, 2026 20:01
@Varixo
Varixo requested a review from a team as a code owner April 8, 2026 20:01
@Varixo Varixo moved this from In progress to Waiting For Review in Qwik Development Apr 8, 2026
@Varixo
Varixo force-pushed the v2-qwikloader-event-handling branch from e0a2ca9 to 7ae409d Compare April 10, 2026 10:14

@wmertens wmertens left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens
wmertens enabled auto-merge April 10, 2026 10:28
@wmertens
wmertens merged commit 19c1653 into build/v2 Apr 10, 2026
26 checks passed
@wmertens
wmertens deleted the v2-qwikloader-event-handling branch April 10, 2026 10:30
@github-project-automation github-project-automation Bot moved this from Waiting For Review to Done in Qwik Development Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants