Skip to content

fix(qwikloader): don't queue user events behind qwik lifecycle handlers - #9018

Merged
maiieul merged 1 commit into
mainfrom
claude/qwikloader-bug-5f30e7
Sep 18, 2026
Merged

maiieul merged 1 commit into
mainfrom
claude/qwikloader-bug-5f30e7

Conversation

@maiieul

@maiieul maiieul commented Sep 18, 2026 •

Copy link
Copy Markdown
Member

What is it?

  • Bug

Description

When clicking during preloading I had to click twice to get the preloader to start preloading the proper chunks.

On slow networks the first click after load was ignored until the router's qcinit imports finished, because every event handler waited in one shared task queue. Qwik lifecycle events (qinit, qidle, qvisible, qcinit, ...) now run right away, and browser events keep their order.

Regression from 7ae409d (#8540), which added the shared queue.

@maiieul
maiieul requested a review from a team as a code owner September 18, 2026 14:45
@maiieul maiieul self-assigned this Sep 18, 2026
@changeset-bot

changeset-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 888321b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@qwik.dev/core Patch
@qwik.dev/devtools Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
@qwik.dev/utils Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maiieul maiieul moved this to Waiting For Review in Qwik Development Sep 18, 2026
@pkg-pr-new

pkg-pr-new Bot commented Sep 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

@qwik.dev/core

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@9018

@qwik.dev/router

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@9018

@qwik.dev/utils

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/utils@9018

eslint-plugin-qwik

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@9018

create-qwik

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@9018

@qwik.dev/optimizer

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/optimizer@9018

@qwik.dev/devtools

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/devtools@9018

commit: 888321b

@Varixo Varixo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions

github-actions Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 888321b

@maiieul
maiieul merged commit 6df9ac9 into main Sep 18, 2026
52 checks passed
@maiieul
maiieul deleted the claude/qwikloader-bug-5f30e7 branch September 18, 2026 15:56
@github-project-automation github-project-automation Bot moved this from Waiting For Review to Done in Qwik Development Sep 18, 2026
This was referenced Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants