Repository navigation
test(web): steady five browser tests that fail on busy CI runners - #606
Merged
Merged
Conversation
…ners (#21699) Co-authored-by: PR Batch Tester <agent@local.test> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 2532e64)
- updateRestartFlow: leaving the update button starts its 150 ms hover-close timer, and opening the popover from focus does not cancel it. Tab once that timer has run, or it closes the focus-opened popover. Reproduced by stretching the delay to 2 s: the old test fails at the CI line, this passes. - PullRequestSummaryTab: wait for the filter menu's items after the click that opens it, instead of looking them up synchronously. - RightPanelTabs keyboard: keep advancing fake frames while real time also passes, until focus returns to the trigger. - AttachmentFilePreview: allow the lazy source view 5 s for its first load. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 19, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 19, 2026
2 of 4 tasks
This was referenced Oct 19, 2026
Merged
yaacovcorcos
pushed a commit
to nattikahana/scient-desktop
that referenced
this pull request
Oct 20, 2026
Bring ScientFactory#353 up to current main, including the T3 alignments ScientFactory#593 and ScientFactory#607 (React Compiler migration, browser test project), ScientFactory#596, ScientFactory#601, ScientFactory#603-ScientFactory#606, ScientFactory#608-ScientFactory#610 and ScientFactory#567. Composition: - Workspace writes: ScientFactory#353's mutation service keeps main's known-workspace boundary and Git-folder write denial. Every write path (write, create, binary write, delete, rename, retained replace/remove, inspect) is authorized first, and the mutation lock re-checks protected paths on each non-history resolution. Test layers provide KnownWorkspaces. - Web: conflicted files follow main's React Compiler patterns (no manual memo, refs synced in layout effects, render-phase resets, effect events, try/finally in module helpers) with ScientFactory#353's behaviour on top, including ScientLatexSurface, the PDF reader, the file preview panel, save coordinator, workspace refresh, Pandoc tool and source PDF preview. - Tests moved to main's browser project are ported (createRoot, async act); ScientFactory#353's deletions of the Markdown rename button and its seam test are kept. - pnpm-lock.yaml regenerated with pnpm install. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Test-only. Five browser tests that fail intermittently on busy CI runners now wait for what they assert.
updateRestartFlow"closing the popover does not swallow a later keyboard focus" (Scient). Moving the pointer off the update button starts its 150 ms hover-close timer, and opening the popover from keyboard focus does not cancel that timer. When Tab lands inside the window, the timer closes the popover the focus just opened. The test now waits out the delay before pressing Tab, as a person would. Reproduced: with the delay temporarily stretched to 2 s (not committed), the old test fails at the CI line and the new one passes.WorkflowOpeningBlock"shows a short script as highlighted code" (upstream). Upstream's own fix, pingdotgg/t3code#21699, cherry-picked unchanged with-xand its author kept, so the next alignment merges cleanly.PullRequestSummaryTabfilter test (upstream). It looked up the filter menu's items synchronously right after the click that opens the menu. It now waits for them, usingvi.waitFor.RightPanelTabskeyboard "uses a custom binding from a text field and closes on Escape" (upstream). It still steps fake animation frames, but now polls in real time too, for up to 5 s instead of 10 instant frames. I did not confirm the root cause. This only lengthens the wait and cannot make the test stricter.AttachmentFilePreview"keeps a renewed URL" (upstream). The source view is lazy-loaded, so the wait for it is now 5 s instead of the default 1 s. This is likely the cause, but it is not reproduced.Each change to an upstream test carries a
SCIENT-FORK:comment.Why
The upstream alignment (#593) added many browser tests. Since it merged, at least one of these five has failed in nearly every merge-queue and PR run today, on PRs that don't touch them. Each failure drops a PR from the queue: #599 and #604 were both dropped this way. The failures are:
updateRestartFlowWorkflowOpeningBlockRightPanelTabskeyboardPullRequestSummaryTabAttachmentFilePreviewNot covered here:
WordFileExport(server) failed once on test(server): keep server tests out of the source checkout #601, reporting "A file in the LaTeX project changed while exporting".Documentation Impact
Documentation impact: None — test-only timing changes; no behavior or workflow change.
Verification
On Windows 11 with headless Chromium:
updateRestartFlowtest fails, and the fixed one passes.vp fmt --checkandvp linton the changed files: clean.Checklist
🤖 Generated with Claude Code