Repository navigation
Fix output capture races and bound stalled CI tests - #447
Merged
Merged
Conversation
Sev7eNup
enabled auto-merge (squash)
September 28, 2026 19:09
3 of 5 tasks
Sev7eNup
added a commit
that referenced
this pull request
Oct 3, 2026
#452) Daily documentation sweep over the pull requests active since 2026-09-28T01:03:39Z. Three surfaces had drifted. #448 allowed same-origin downloads in the Electron shell, added the computer-use acceptance gate and made globals resolve inside a custom activity definition: - deploy/desktop/README.md and content/{de,en}/deployment/desktop.md still listed downloads among the things the shell blocks outright. - The tray entry the shell README tells you to use is now "Quit NodePilot". - CLAUDE.md counted three mandatory release runs; scripts/release-lab/ computer-use/ is a fourth, and RELEASING.md step 6 describes it. - docs/custom-activities.md and content/{de,en}/concepts/data-bus.md described the globals contract for runScript only, although a {{globals.X}} in a ScriptTemplate or an input default now resolves and fails the step when it is missing or undecryptable. #446 renamed the designer's run button from "Test run" to "Run" ("Ausführen"). docs/workflow-designer-features.md and both language versions of designer/properties-modes.md still named the old label, including in their keyboard-shortcut tables. Verified against the checked-out main rather than the pull request diffs. The counts these changes could have invalidated all still match the code: 27 activity types, 10 skins, 242 vitest files, 77 E2E specs. #447 carried its own documentation across docs/claude-reference.md and both copies of activities-reference.md, so the startProgram drain semantics needed no edit. Claude-Session: https://claude.ai/code/session_018Hdn3USoyZs9C2DQ3LboAA Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
CI exposed both timing-dependent tests and actual output loss: startProgram stopped reading five seconds after the child exited even while it was still collecting buffered stderr. A delayed reader could therefore return a successful result with missing lines. A stalled backend run also kept Actions occupied for more than 23 minutes without identifying the stuck test.
Changes
No retries or skipped checks are added.
Validation
Unrelated Dependabot Quartz API incompatibilities are outside this change.