Repository navigation
docs: sync after #448 and #446 (desktop downloads, run button, release gate) - #452
Merged
Merged
Conversation
Daily documentation sweep over the pull requests active since 2026-09-28T01:03:39Z. Three surfaces had drifted. #448 allowed same-origin downloads in the Electron shell, added the computer-use acceptance gate and made globals resolve inside a custom activity definition: - deploy/desktop/README.md and content/{de,en}/deployment/desktop.md still listed downloads among the things the shell blocks outright. - The tray entry the shell README tells you to use is now "Quit NodePilot". - CLAUDE.md counted three mandatory release runs; scripts/release-lab/ computer-use/ is a fourth, and RELEASING.md step 6 describes it. - docs/custom-activities.md and content/{de,en}/concepts/data-bus.md described the globals contract for runScript only, although a {{globals.X}} in a ScriptTemplate or an input default now resolves and fails the step when it is missing or undecryptable. #446 renamed the designer's run button from "Test run" to "Run" ("Ausführen"). docs/workflow-designer-features.md and both language versions of designer/properties-modes.md still named the old label, including in their keyboard-shortcut tables. Verified against the checked-out main rather than the pull request diffs. The counts these changes could have invalidated all still match the code: 27 activity types, 10 skins, 242 vitest files, 77 E2E specs. #447 carried its own documentation across docs/claude-reference.md and both copies of activities-reference.md, so the startProgram drain semantics needed no edit. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018Hdn3USoyZs9C2DQ3LboAA
This was referenced Sep 29, 2026
5 of 6 tasks
Sev7eNup
added a commit
that referenced
this pull request
Oct 3, 2026
- #462: guard the documentation page count, add llms.txt to the 1.4.4 changelog, mark seo-local-review.md as a dated record, drop the stale figure from a code comment. - #460: shorten failing readiness rows as a last step so a fail-heavy run fits the page; move the GitHub language and trailer conventions into CONTRIBUTING.md. - #456: drop the Electron version from prose that only restated it, and make the embedded-Node note fail the contract test on the next bump. - #454: state that a run without the edit lock uses the saved definition's parameters. - #453: retire the decided desktop-download question from the roadmap, relabel and guard the release-lab catalog counts. - #449: document that the computer-use baseline is refreshed per run. - #440: list all demo specs in the guard table and catalogue the ten guided walkthroughs as Teil 86. Also restores CLAUDE.md's three release gates: #452 had re-added the computer-use run as a fourth after it was marked experimental. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Daily documentation-drift sweep over the pull requests active since
2026-09-28T01:03:39Z(#439, #441, #442, #443, #444, #445, #446, #447, #448). Two merged pull requests left documentation claims behind; each correction below names the pull request that caused it.Caused by #448 — the Electron shell now allows same-origin downloads, a fourth release gate landed, and globals resolve inside a custom activity definition:
deploy/desktop/README.md(hardening bullet)downloadsamong the things blocked outrightcontent/de/deployment/desktop.md,content/en/deployment/desktop.mddeploy/desktop/README.md(dev-loop note)CLAUDE.md§ Production Deploymentscripts/release-lab/computer-use/and counts vierdocs/custom-activities.md{{globals.X}}appearing only in theScriptTemplateor an input default resolves; missing or undecryptable fails the step before the script runscontent/de/concepts/data-bus.md,content/en/concepts/data-bus.mdrunScript" / "including inside arunScript"Caused by #446 — the designer's run button was renamed from "Test run" to "Run" (
Ausführen):docs/workflow-designer-features.md§ 11Ctrl+Enter)Ctrl+Enter)docs/workflow-designer-features.mdshortcut tablecontent/en/designer/properties-modes.mdcontent/de/designer/properties-modes.mdHow
Verified against the checked-out
main(b49402d), not against the pull request diffs. The run-button label comes fromtestRuninsrc/nodepilot-ui/src/i18n/locales/{de,en}/editor.json, used as the buttontitle/aria-labelinheader/RunControls.tsx; the download rule fromhardenSessioninsrc/nodepilot-desktop/src/security.ts(origin check acrosscontents.getURL(),item.getURL()and the fullgetURLChain()); the globals contract fromCustomActivityExecutor.FindUnavailableGlobals, which fails the step beforeResolveScriptVariablesruns; the fourth gate fromRELEASING.mdstep 6 andscripts/release-lab/README.md.Re-checked every count-bearing claim these pull requests could have invalidated — all match the code: 27 activity types (
ActivityCatalog.cs), 10 skins (themeStore.ts), 242 vitest files and 77 E2E specs (CLAUDE.md, already updated by #446).CLAUDE.mdis 45,888 bytes against the 50,000-byte cap inDocumentationCountsTests.#447 carried its own documentation:
docs/claude-reference.mdand both copies ofactivities-reference.mdalready describe the newstartProgramdrain semantics consistently, so nothing there needed an edit. #441–#445 are dependency bumps with no user-facing surface, and #439 is the previous sweep's own pull request (it touches onlysrc/nodepilot-ui/CLAUDE.md, so there is no overlap with this branch).Three findings were deliberately not applied and are filed as docs-drift issues for triage: the resolved audit open question in
docs/roadmap.md, the desktop README's known-gaps wording, and the new count-bearing claims inscripts/release-lab/README.mdthat sit outsideDocumentationCountsTestsand use a different basis for "Activity types" and "themes" than every other surface.Testing
Documentation only — no code, no configuration, no test files touched. Both language copies of every changed site page were edited symmetrically, and no cross-reference or page was added or removed.
dotnet test(affected backend suites) green — not run: no .NET SDK in this container and the suites targetnet10.0-windows.DocumentationCountsTestsis the relevant guard; its inputs were verified by hand above. Covered by CI.npm run test:run— not run:src/nodepilot-docs-ui/node_modulesis absent in this container. Covered by CI.Checklist
main; no direct commits tomaincontent/de/andcontent/en/) if behavior or config changed — this change is the documentation update, applied bilingually🤖 Generated with Claude Code
https://claude.ai/code/session_018Hdn3USoyZs9C2DQ3LboAA
Generated by Claude Code