Skip to content

docs: sync after #448 and #446 (desktop downloads, run button, release gate) - #452

Merged
Sev7eNup merged 1 commit into
mainfrom
docs/auto-sync-2026-09-29
Oct 3, 2026
Merged

Sev7eNup merged 1 commit into
mainfrom
docs/auto-sync-2026-09-29

Conversation

@Sev7eNup

Copy link
Copy Markdown
Owner

What & why

Daily documentation-drift sweep over the pull requests active since 2026-09-28T01:03:39Z (#439, #441, #442, #443, #444, #445, #446, #447, #448). Two merged pull requests left documentation claims behind; each correction below names the pull request that caused it.

Caused by #448 — the Electron shell now allows same-origin downloads, a fourth release gate landed, and globals resolve inside a custom activity definition:

Doc surface Was Now
deploy/desktop/README.md (hardening bullet) listed downloads among the things blocked outright downloads allowed only when the whole URL chain stays on the app's own origin, destination chosen by Electron's native Save As dialog
content/de/deployment/desktop.md, content/en/deployment/desktop.md "Pop-ups, Downloads und Berechtigungsanfragen sind deaktiviert" / "pop-ups, downloads and permission requests are disabled" downloads split into their own bullet with the same-origin + Save As rule
deploy/desktop/README.md (dev-loop note) tray → Quit Electron tray → Quit NodePilot
CLAUDE.md § Production Deployment "Ohne grünen Lauf aller drei kein Tag" names scripts/release-lab/computer-use/ and counts vier
docs/custom-activities.md globals only described for the node's config new bullet: a {{globals.X}} appearing only in the ScriptTemplate or an input default resolves; missing or undecryptable fails the step before the script runs
content/de/concepts/data-bus.md, content/en/concepts/data-bus.md "auch innerhalb eines runScript" / "including inside a runScript" adds custom activities to the same guarantee

Caused by #446 — the designer's run button was renamed from "Test run" to "Run" (Ausführen):

Doc surface Was Now
docs/workflow-designer-features.md § 11 Test run (Ctrl+Enter) Run (Ctrl+Enter)
docs/workflow-designer-features.md shortcut table Test run / debug run Run / debug run
content/en/designer/properties-modes.md Test run: runs the workflow as a test; "Start a test run"; "A running test can be cancelled" Run:; "Start a run"; "A running execution can be cancelled"
content/de/designer/properties-modes.md Test Run:; "Testlauf starten"; "Ein laufender Test kann abgebrochen werden" Ausführen:; "Ausführung starten"; "Eine laufende Ausführung kann abgebrochen werden"

How

Verified against the checked-out main (b49402d), not against the pull request diffs. The run-button label comes from testRun in src/nodepilot-ui/src/i18n/locales/{de,en}/editor.json, used as the button title/aria-label in header/RunControls.tsx; the download rule from hardenSession in src/nodepilot-desktop/src/security.ts (origin check across contents.getURL(), item.getURL() and the full getURLChain()); the globals contract from CustomActivityExecutor.FindUnavailableGlobals, which fails the step before ResolveScriptVariables runs; the fourth gate from RELEASING.md step 6 and scripts/release-lab/README.md.

Re-checked every count-bearing claim these pull requests could have invalidated — all match the code: 27 activity types (ActivityCatalog.cs), 10 skins (themeStore.ts), 242 vitest files and 77 E2E specs (CLAUDE.md, already updated by #446). CLAUDE.md is 45,888 bytes against the 50,000-byte cap in DocumentationCountsTests.

#447 carried its own documentation: docs/claude-reference.md and both copies of activities-reference.md already describe the new startProgram drain semantics consistently, so nothing there needed an edit. #441–#445 are dependency bumps with no user-facing surface, and #439 is the previous sweep's own pull request (it touches only src/nodepilot-ui/CLAUDE.md, so there is no overlap with this branch).

Three findings were deliberately not applied and are filed as docs-drift issues for triage: the resolved audit open question in docs/roadmap.md, the desktop README's known-gaps wording, and the new count-bearing claims in scripts/release-lab/README.md that sit outside DocumentationCountsTests and use a different basis for "Activity types" and "themes" than every other surface.

Testing

Documentation only — no code, no configuration, no test files touched. Both language copies of every changed site page were edited symmetrically, and no cross-reference or page was added or removed.

  • New/updated tests cover the change — n/a, documentation only
  • dotnet test (affected backend suites) green — not run: no .NET SDK in this container and the suites target net10.0-windows. DocumentationCountsTests is the relevant guard; its inputs were verified by hand above. Covered by CI.
  • npm run test:run — not run: src/nodepilot-docs-ui/node_modules is absent in this container. Covered by CI.

Checklist

  • Branched off main; no direct commits to main
  • Docs updated (README / CLAUDE.md / docs/ / docs-ui content/de/ and content/en/) if behavior or config changed — this change is the documentation update, applied bilingually

🤖 Generated with Claude Code

https://claude.ai/code/session_018Hdn3USoyZs9C2DQ3LboAA


Generated by Claude Code

Daily documentation sweep over the pull requests active since
2026-09-28T01:03:39Z. Three surfaces had drifted.

#448 allowed same-origin downloads in the Electron shell, added the
computer-use acceptance gate and made globals resolve inside a custom
activity definition:

- deploy/desktop/README.md and content/{de,en}/deployment/desktop.md still
  listed downloads among the things the shell blocks outright.
- The tray entry the shell README tells you to use is now "Quit NodePilot".
- CLAUDE.md counted three mandatory release runs; scripts/release-lab/
  computer-use/ is a fourth, and RELEASING.md step 6 describes it.
- docs/custom-activities.md and content/{de,en}/concepts/data-bus.md
  described the globals contract for runScript only, although a
  {{globals.X}} in a ScriptTemplate or an input default now resolves and
  fails the step when it is missing or undecryptable.

#446 renamed the designer's run button from "Test run" to "Run"
("Ausführen"). docs/workflow-designer-features.md and both language
versions of designer/properties-modes.md still named the old label,
including in their keyboard-shortcut tables.

Verified against the checked-out main rather than the pull request diffs.
The counts these changes could have invalidated all still match the code:
27 activity types, 10 skins, 242 vitest files, 77 E2E specs. #447 carried
its own documentation across docs/claude-reference.md and both copies of
activities-reference.md, so the startProgram drain semantics needed no
edit.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018Hdn3USoyZs9C2DQ3LboAA
@Sev7eNup
Sev7eNup merged commit 1a729ba into main Oct 3, 2026
10 checks passed
@Sev7eNup
Sev7eNup deleted the docs/auto-sync-2026-09-29 branch October 3, 2026 09:21
Sev7eNup added a commit that referenced this pull request Oct 3, 2026
- #462: guard the documentation page count, add llms.txt to the 1.4.4
  changelog, mark seo-local-review.md as a dated record, drop the stale
  figure from a code comment.
- #460: shorten failing readiness rows as a last step so a fail-heavy
  run fits the page; move the GitHub language and trailer conventions
  into CONTRIBUTING.md.
- #456: drop the Electron version from prose that only restated it, and
  make the embedded-Node note fail the contract test on the next bump.
- #454: state that a run without the edit lock uses the saved
  definition's parameters.
- #453: retire the decided desktop-download question from the roadmap,
  relabel and guard the release-lab catalog counts.
- #449: document that the computer-use baseline is refreshed per run.
- #440: list all demo specs in the guard table and catalogue the ten
  guided walkthroughs as Teil 86.

Also restores CLAUDE.md's three release gates: #452 had re-added the
computer-use run as a fourth after it was marked experimental.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant