Skip to content

Docs-Sync #446: run parameters come from the saved definition without a write lock #454

Closed

Description

@Sev7eNup

Source pull request: #446

Affected doc surface: docs/workflow-designer-features.md (the complete designer feature inventory).

The objective drift from #446 — the run button's rename from "Test run" to "Run" / "Ausführen" across docs/workflow-designer-features.md and both language versions of content/*/designer/properties-modes.md — is already corrected in #452. One finding was deliberately not applied.

  • docs/workflow-designer-features.md § 11 Running from the designer does not distinguish where the run's trigger parameters come from. The bullet says a run "starts immediately, or opens the parameter dialog for a manualTrigger that declares parameters". Fix guidance and navigation across all ten demo walkthroughs #446 changed useWorkflowExecution.ts so that the dialog is derived from the canvas ({ nodes, edges }) only when canWrite is true, and from workflow.definitionJson otherwise — a published run executes the saved definition, and a canvas that is still hydrating must not let the run bypass its parameters. Not auto-applied: it is a judgement call whether this is a user-facing contract the inventory should state (it changes which parameters you are asked for when you do not hold the edit lock) or an implementation detail of a bug fix that the doc is right to omit. The surrounding bullets describe user-visible behaviour, not data sources, so adding it would set a new level of detail for the section.

Automated docs-drift finding from the daily documentation-sync routine — needs triage.

Activity

  1. Sev7eNup commented on Oct 3, 2026

    @Sev7eNup
    OwnerAuthor

    Resolved in #466 (and #463 for the earlier findings).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions