Repository navigation
Fix doc-sync and review findings from #449, #450, #460 - #463
Merged
Merged
Conversation
- Rename "Test run" to "Run"/"Ausführen" in the six documentation places that still used the old editor label (#450). - llms.txt now links pages with the canonical trailing slash instead of the redirect-hop form (#460). - gate.py's uiSourceHash no longer hashes __tests__/*.tsx and *.test.tsx, so test-only UI changes stop invalidating the computer-use coverage review (#449). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Build-DesktopInstaller.ps1's .DESCRIPTION still named 43.4.1; main has pinned 43.7.6 since the last bump, independent of the still-open #441. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…CI flakiness ps.Stop() runs synchronously inside the cancellation callback. On a contended CI runner that occasionally took longer than the test's 30s wait, so task.WaitAsync() timed out before observing the OperationCanceledException and failed the test (seen on main and on #459/#442's reruns). Widen both bounds to 90s. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ps.Stop() on a RunspacePool-backed BeginInvoke can occasionally never signal completion (a known PowerShell SDK gap, e.g. PowerShell/PowerShell#17250). ExecuteOnceAsync now gives the pipeline a 20s grace period after Stop() fires; past that it abandons the pipeline and throws cancellation anyway instead of hanging the caller forever. ps.Dispose() is skipped in that case since it can block on the same stuck pipeline — the runspace is deliberately leaked and logged loudly so an operator can restart the service. Reproduced on CI: RunspaceEngineAsyncTests.Execute_CallerCancellation_ ThrowsInsteadOfReturningAFailedResult failed at exactly its wait bound twice in a row (30s, then 90s), the signature of a stuck pipeline rather than CI contention. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| if (ct.IsCancellationRequested) | ||
| { | ||
| ps.Dispose(); |
| if (!success && errors.Length == 0) | ||
| errors.Append(invocationState.Reason?.Message | ||
| ?? $"Script execution ended in state '{invocationState.State}'."); | ||
| ps.Dispose(); |
This was referenced Oct 3, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
llms.txtnow links pages with the canonical trailing slash instead of the redirect-hop form, matchingsitemap()andsiteHref()(PR-Review #458: llms.txt links bypass the canonical trailing slash, the prerequisites fix misses the fail-heavy case, and CLAUDE.md commit rules were dropped without relocation #460).gate.py'suiSourceHashno longer hashes__tests__/*.tsxand*.test.tsx, so test-only UI changes stop invalidating the computer-use coverage review (PR-Review #448: computer-use gate hashes 154 test files as "UI sources", and an unannounced CLAUDE.md policy rewrite rides along #449, first finding only — the "no CI runs the gate" finding is left for a separate decision).Test plan
npx vitest run src/site/prerender.test.ts(nodepilot-docs-ui) — 18 passedpython scripts/release-lab/computer-use/gate.py catalog— passes with the refreshed hashpython -m pytest test_gate.py— 6 passedCloses #450, #460. Addresses the first finding of #449.
🤖 Generated with Claude Code